Bug 92662

Summary: fast/writing-mode/flipped-blocks-hit-test-line-edges.html broken on non-Mac Chromium
Product: WebKit Reporter: Tom Hudson <tomhudson>
Component: Layout and RenderingAssignee: Peter Kasting <pkasting>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, pkasting, rniwa, tomhudson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 92597    
Attachments:
Description Flags
patch v1 none

Tom Hudson
Reported 2012-07-30 11:09:05 PDT
It isn't clear if the layout test is telling us that: 1. there's a Chromium bug; non-Mac should render like Mac and isn't 2. the test needs to be modified so the results aren't platform dependent 3. the test needs to be modified to expect platform-dependent results
Attachments
patch v1 (1.20 KB, patch)
2012-07-30 12:20 PDT, Peter Kasting 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tom Hudson
Comment 1 2012-07-30 11:09:47 PDT
mitz, rniwa, could you give us some guidance on how you expect Chromium to handle this layout test?
Ryosuke Niwa
Comment 2 2012-07-30 11:50:50 PDT
https://bugs.webkit.org/show_bug.cgi?id=92636 --- Comment #3 from mitz@webkit.org 2012-07-30 07:16:06 PST --- The test is failing because of the different selection mode used in some non-OS X ports.
mitz
Comment 3 2012-07-30 11:52:48 PDT
I think there may be a way for TestRunner or Internals to change the selection behavior, so that’s one option. Another option would be to consider both possible results as PASS. Yet another option would be to just remove that point from the test.
mitz
Comment 4 2012-07-30 11:54:33 PDT
internals.settings.setEditingBehavior('mac') should do the trick.
Peter Kasting
Comment 5 2012-07-30 12:20:53 PDT
Created attachment 155336 [details] patch v1 So, something like this then?
Ryosuke Niwa
Comment 6 2012-07-30 13:33:57 PDT
Thanks for the fix.
Peter Kasting
Comment 7 2012-07-30 13:46:11 PDT
Fixed in r124084.
Note You need to log in before you can comment on or make changes to this bug.