Bug 92659 – [css] Prefer usage of RenderStyle::textDecorationsInEffect() when rendering

• Component: CSS
• Status: RESOLVED FIXED

[Bruno Abinader (history only)]

WebKit currently has a proprietary CSS property '-webkit-text-decorations-in-effect', which as far as I've studied on the code and tested, is only used internally as part of the 'text-decoration' CSS property implementation (as up to CSS spec 2.1). Inside WebCore/rendering, there are mixed usage of both RenderStyle::textDecoration() and RenderStyle::textDecorationsInEffect(). To avoid a possible breach in terms of data redundancy, prefer usage of RenderStyle::textDecorationsInEffect() sounds more correct, after render style adjustments.

[Bruno Abinader (history only)]

Created attachment 155322 [details]
Patch

[WebKit Review Bot]

Comment on attachment 155322 [details]
Patch

Attachment 155322 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13386544

New failing tests:
fast/css/first-line-text-decoration-inherited-from-parent.html
fast/selectors/visited-descendant.html
svg/text/text-deco-01-b.svg
svg/batik/text/textDecoration2.svg
css1/basic/inheritance.html
fast/ruby/text-decoration-in-descendants-ruby.html
svg/W3C-SVG-1.1/text-deco-01-b.svg
svg/batik/text/textDecoration.svg
fast/css/child-style-can-override-visited-style.html
css2.1/20110323/c543-txt-decor-000.html

[WebKit Review Bot]

Created attachment 155335 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Bruno Abinader (history only)]

Comment on attachment 155322 [details]
Patch

Hmm, seems that I completely misunderstoond the concept here, thus I haven't attached this part of the patch into bug 90959... removing review request.

[Bruno Abinader (history only)]

Actually not quite fully invalid :) I just found a breach while implementing patch for -webkit-text-decoration-color (bug 91638) where textDecorationsInEffect() is saner than textDecoration() usage: inside RenderObject::getTextDecorationColors, where colors for underline, overline and linethrough are obtained. However, there is no sense in having a separate patch for this change, which makes more sense to be part of that patch.