Summary: | [css] Prefer usage of RenderStyle::textDecorationsInEffect() when rendering | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bruno Abinader (history only) <bruno.abinader> | ||||||
Component: | CSS | Assignee: | Bruno Abinader (history only) <bruno.abinader> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, eric, igor.oliveira, jchaffraix, peter, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 93863 | ||||||||
Bug Blocks: | 58491 | ||||||||
Attachments: |
|
Description
Bruno Abinader (history only)
2012-07-30 10:45:50 PDT
Created attachment 155322 [details]
Patch
Comment on attachment 155322 [details] Patch Attachment 155322 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13386544 New failing tests: fast/css/first-line-text-decoration-inherited-from-parent.html fast/selectors/visited-descendant.html svg/text/text-deco-01-b.svg svg/batik/text/textDecoration2.svg css1/basic/inheritance.html fast/ruby/text-decoration-in-descendants-ruby.html svg/W3C-SVG-1.1/text-deco-01-b.svg svg/batik/text/textDecoration.svg fast/css/child-style-can-override-visited-style.html css2.1/20110323/c543-txt-decor-000.html Created attachment 155335 [details]
Archive of layout-test-results from gce-cr-linux-02
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 155322 [details] Patch Hmm, seems that I completely misunderstoond the concept here, thus I haven't attached this part of the patch into bug 90959... removing review request. Actually not quite fully invalid :) I just found a breach while implementing patch for -webkit-text-decoration-color (bug 91638) where textDecorationsInEffect() is saner than textDecoration() usage: inside RenderObject::getTextDecorationColors, where colors for underline, overline and linethrough are obtained. However, there is no sense in having a separate patch for this change, which makes more sense to be part of that patch. |