| Summary: | In flipped blocks, a point on the top edge of a text box is considered outside the box (and vice versa) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | HTML Editing | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eae, eric, jbadics, leviw, mifenton, rniwa, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 92636, 92662 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
mitz
2012-07-29 14:11:43 PDT
Created attachment 155182 [details]
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa
Comment on attachment 155182 [details]
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa
Makes sense.
This should probably in the editing for consistency. We should really add a "Hit testing" component. Fixed in <http://trac.webkit.org/r123988>. Unfortunately r123988 made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail on Qt WebKit1. I have created a bug for it on the following link: https://bugs.webkit.org/show_bug.cgi?id=92636 Comment on attachment 155182 [details] When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa View in context: https://bugs.webkit.org/attachment.cgi?id=155182&action=review > LayoutTests/fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt:10 > +PASS: offset at (60,24) was 26. This new test case fail on Qt and Chromium Linux too. See the bug report mentioned by the previous comment. Comment on attachment 155182 [details]
When comparing y coordinates in flipped text, make strict inequalities non-strict and vice versa
Clearing flags.
|