| Summary: | Replace UnicodeWinCE with UnicodeWchar | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||||||
| Component: | Web Template Framework | Assignee: | Patrick R. Gansterer <paroga> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dglazkov, gyuyoung.kim, mifenton, rakuco, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | 47977 | ||||||||||||
| Bug Blocks: | 108094 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Patrick R. Gansterer
2012-07-27 12:53:17 PDT
Created attachment 155032 [details]
Patch
Attachment 155032 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WTF/ChangeLog', u'Sou..." exit_code: 1
Source/WTF/wtf/unicode/wchar/UnicodeWchar.cpp:25: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 155037 [details]
Patch
Created attachment 155040 [details]
Patch
Comment on attachment 155040 [details] Patch Attachment 155040 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13377642 Created attachment 155066 [details]
Patch
Comment on attachment 155066 [details]
Patch
rs=me.
Committed r124010: <http://trac.webkit.org/changeset/124010> |