Bug 92539

Summary:

Replace UnicodeWinCE with UnicodeWchar

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Web Template Framework

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gyuyoung.kim, mifenton, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

47977

Bug Blocks:

108094

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	webkit.review.bot: commit-queue-
Patch	rniwa: review+

Patrick R. Gansterer

Reported 2012-07-27 12:53:17 PDT

Replace UnicodeWinCE with UnicodeWchar

Attachments
Patch (30.11 KB, patch) 2012-07-27 13:04 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Patch (30.13 KB, patch) 2012-07-27 13:18 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
Patch (30.15 KB, patch) 2012-07-27 13:44 PDT, Patrick R. Gansterer	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (30.84 KB, patch) 2012-07-27 15:26 PDT, Patrick R. Gansterer	rniwa: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2012-07-27 13:04:12 PDT

Created attachment 155032 [details] Patch

WebKit Review Bot

Comment 2 2012-07-27 13:13:04 PDT

Attachment 155032 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WTF/ChangeLog', u'Sou..." exit_code: 1 Source/WTF/wtf/unicode/wchar/UnicodeWchar.cpp:25: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Patrick R. Gansterer

Comment 3 2012-07-27 13:18:24 PDT

Created attachment 155037 [details] Patch

Patrick R. Gansterer

Comment 4 2012-07-27 13:44:28 PDT

Created attachment 155040 [details] Patch

WebKit Review Bot

Comment 5 2012-07-27 15:19:22 PDT

Comment on attachment 155040 [details] Patch Attachment 155040 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13377642

Patrick R. Gansterer

Comment 6 2012-07-27 15:26:53 PDT

Created attachment 155066 [details] Patch