Bug 92407

Summary: [EFL][WK2] Add more Ewk_View unit tests
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, hausmann, kenneth, ryuan.choi, tmpsantos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-07-26 11:37:26 PDT
We need more Ewk_View unit tests. In particular, the following methods are not tested: - ewk_view_back_possible() - ewk_view_forward_possible() - ewk_view_back() - ewk_view_forward() - ewk_view_html_string_load() - ewk_view_device_pixel_ratio_get() - ewk_view_device_pixel_ratio_set()
Attachments
Patch (7.67 KB, patch)
2012-07-26 11:42 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-07-26 11:42:41 PDT
Created attachment 154705 [details] Patch
Thiago Marcos P. Santos
Comment 2 2012-07-26 12:22:27 PDT
Comment on attachment 154705 [details] Patch LGTM! Thanks for adding waitUntilTitleChangedTo(). This is a valuable asset for the test suite.
WebKit Review Bot
Comment 3 2012-07-27 04:13:18 PDT
Comment on attachment 154705 [details] Patch Clearing flags on attachment: 154705 Committed r123863: <http://trac.webkit.org/changeset/123863>
WebKit Review Bot
Comment 4 2012-07-27 04:13:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.