Bug 92407 - [EFL][WK2] Add more Ewk_View unit tests
Summary: [EFL][WK2] Add more Ewk_View unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency treegraph
 
Reported: 2012-07-26 11:37 PDT by Chris Dumez
Modified: 2012-07-27 04:13 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.67 KB, patch)
2012-07-26 11:42 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-07-26 11:37:26 PDT
We need more Ewk_View unit tests. In particular, the following methods are not tested:
 - ewk_view_back_possible()
 - ewk_view_forward_possible()
 - ewk_view_back()
 - ewk_view_forward()
 - ewk_view_html_string_load()
 - ewk_view_device_pixel_ratio_get()
 - ewk_view_device_pixel_ratio_set()
Comment 1 Chris Dumez 2012-07-26 11:42:41 PDT
Created attachment 154705 [details]
Patch
Comment 2 Thiago Marcos P. Santos 2012-07-26 12:22:27 PDT
Comment on attachment 154705 [details]
Patch

LGTM! Thanks for adding waitUntilTitleChangedTo(). This is a valuable asset for the test suite.
Comment 3 WebKit Review Bot 2012-07-27 04:13:18 PDT
Comment on attachment 154705 [details]
Patch

Clearing flags on attachment: 154705

Committed r123863: <http://trac.webkit.org/changeset/123863>
Comment 4 WebKit Review Bot 2012-07-27 04:13:24 PDT
All reviewed patches have been landed.  Closing bug.