Bug 92341

Summary: Add message traces when media and plugins load or fail to load.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric.carlson, feature-media-reviews, gns, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 92336, 92340    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch andersca: review+, webkit.review.bot: commit-queue-

Description Jer Noble 2012-07-25 23:50:06 PDT
Add message traces when media and plugins load or fail to load.
Comment 1 Jer Noble 2012-07-26 00:12:36 PDT
Created attachment 154561 [details]
Patch
Comment 2 Early Warning System Bot 2012-07-26 00:43:57 PDT
Comment on attachment 154561 [details]
Patch

Attachment 154561 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13351563
Comment 3 WebKit Review Bot 2012-07-26 00:44:55 PDT
Comment on attachment 154561 [details]
Patch

Attachment 154561 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13351556
Comment 4 Early Warning System Bot 2012-07-26 00:49:06 PDT
Comment on attachment 154561 [details]
Patch

Attachment 154561 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13361409
Comment 5 Gyuyoung Kim 2012-07-26 01:00:48 PDT
Comment on attachment 154561 [details]
Patch

Attachment 154561 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13342624
Comment 6 Gustavo Noronha (kov) 2012-07-26 01:33:20 PDT
Comment on attachment 154561 [details]
Patch

Attachment 154561 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13351583
Comment 7 Eric Carlson 2012-07-26 05:52:57 PDT
Comment on attachment 154561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154561&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:1520
> +    default: return emptyString();

Shouldn't this have ASSERT_NOT_REACHED?

> Source/WebCore/html/HTMLMediaElement.cpp:1701
>          scheduleEvent(eventNames().loadeddataEvent);
>          setShouldDelayLoadEvent(false);
> +        if (document()->page() && document()->page()->settings()->messageTracingEnabled())
> +            document()->page()->chrome()->client()->traceMessage(ChromeClient::MediaLoaded, m_player->engineDescription());

I think it would be better to do this when we reach HAVE_METADATA, or an element with "preload=metadata" may not ever notify the client even thought it found and loaded part of a valid media file.
Comment 8 Jer Noble 2012-07-26 08:06:38 PDT
(In reply to comment #7)
> (From update of attachment 154561 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154561&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:1520
> > +    default: return emptyString();
> 
> Shouldn't this have ASSERT_NOT_REACHED?

Sure.

> > Source/WebCore/html/HTMLMediaElement.cpp:1701
> >          scheduleEvent(eventNames().loadeddataEvent);
> >          setShouldDelayLoadEvent(false);
> > +        if (document()->page() && document()->page()->settings()->messageTracingEnabled())
> > +            document()->page()->chrome()->client()->traceMessage(ChromeClient::MediaLoaded, m_player->engineDescription());
> 
> I think it would be better to do this when we reach HAVE_METADATA, or an element with "preload=metadata" may not ever notify the client even thought it found and loaded part of a valid media file.

Is HAVE_METADATA guaranteed to only fire once?  (It looks like we will never drop down below HAVE_METADATA unless the user cancels load.  So yes.)
Comment 9 Jer Noble 2012-07-26 10:57:15 PDT
Created attachment 154688 [details]
Patch
Comment 10 WebKit Review Bot 2012-07-26 11:13:23 PDT
Comment on attachment 154688 [details]
Patch

Attachment 154688 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13351831
Comment 11 Early Warning System Bot 2012-07-26 11:13:58 PDT
Comment on attachment 154688 [details]
Patch

Attachment 154688 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13345862
Comment 12 Early Warning System Bot 2012-07-26 11:18:47 PDT
Comment on attachment 154688 [details]
Patch

Attachment 154688 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13342893
Comment 13 Gyuyoung Kim 2012-07-26 11:22:43 PDT
Comment on attachment 154688 [details]
Patch

Attachment 154688 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13340887
Comment 14 Jer Noble 2012-07-26 12:01:40 PDT
Committed r123780: <http://trac.webkit.org/changeset/123780>