Bug 92336 – Add a MediaPlayer API to retrieve the description of the current media engine.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Add a MediaPlayer API to retrieve the description of the current media engine.

[Jer Noble]

Created attachment 154555 [details]
Patch

[Eric Carlson]

Comment on attachment 154555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154555&action=review

How about platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h? You could also change Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h, but it is probably better to just file a bug.

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:134
> +    virtual String engineDescription() const { return ""; }

Did you mean to leave this blank?

[Jer Noble]

(In reply to comment #2)
> (From update of attachment 154555 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154555&action=review
> 
> How about platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h? 

Yep, missed that one. I'll add it.

> You could also change Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h, but it is probably better to just file a bug.

Might as well just do it in this patch.

> > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:134
> > +    virtual String engineDescription() const { return ""; }
> 
> Did you mean to leave this blank?

Nope, I'll fill that one in too.

Thanks!

[Jer Noble]

(In reply to comment #3)
> (In reply to comment #2)
> > You could also change Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h, but it is probably better to just file a bug.
> 
> Might as well just do it in this patch.

Nevermind, I'll file a bug.

[Jer Noble]

Committed r123747: <http://trac.webkit.org/changeset/123747>