Bug 92337

Summary: Add setting to enable and disable message tracing.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 92340    
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Jer Noble
Reported 2012-07-25 23:23:24 PDT
Add setting to enable and disable message tracing.
Attachments
Patch (11.52 KB, patch)
2012-07-26 00:05 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (11.58 KB, patch)
2012-07-26 08:42 PDT, Jer Noble 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-07-26 00:05:27 PDT
Created attachment 154557 [details] Patch
Mark Rowe (bdash)
Comment 2 2012-07-26 00:59:23 PDT
While "message tracing" is a term we use for this, I don't think it's descriptive enough to use within WebKit and WebCore. Something like "diagnostic event recording" would be more descriptive of what it does.
Mark Rowe (bdash)
Comment 3 2012-07-26 01:05:31 PDT
And given that you're not implementing the relevant ChromeClient methods for WebKit1, why bother adding the preference code at all for it?
Jer Noble
Comment 4 2012-07-26 07:50:39 PDT
(In reply to comment #3) > And given that you're not implementing the relevant ChromeClient methods for WebKit1, why bother adding the preference code at all for it? The WebKit1 support will come in a future patch. I'm trying to break them up into digestible pieces. :)
Jer Noble
Comment 5 2012-07-26 07:53:51 PDT
(In reply to comment #2) > While "message tracing" is a term we use for this, I don't think it's descriptive enough to use within WebKit and WebCore. Something like "diagnostic event recording" would be more descriptive of what it does. Fair point, but "event" is a pretty overloaded term already in WebCore, whereas "trace/tracing" isn't. Perhaps "diagnostic tracing"? "Diagnostic logging"?
Jer Noble
Comment 6 2012-07-26 08:42:39 PDT
Created attachment 154658 [details] Patch Renamed everything "diagnostic logging".
Jer Noble
Comment 7 2012-07-26 11:26:54 PDT
Committed r123775: <http://trac.webkit.org/changeset/123775>
Note You need to log in before you can comment on or make changes to this bug.