| Summary: | Add setting to enable and disable message tracing. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | mrowe | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 92340 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jer Noble
2012-07-25 23:23:24 PDT
Created attachment 154557 [details]
Patch
While "message tracing" is a term we use for this, I don't think it's descriptive enough to use within WebKit and WebCore. Something like "diagnostic event recording" would be more descriptive of what it does. And given that you're not implementing the relevant ChromeClient methods for WebKit1, why bother adding the preference code at all for it? (In reply to comment #3) > And given that you're not implementing the relevant ChromeClient methods for WebKit1, why bother adding the preference code at all for it? The WebKit1 support will come in a future patch. I'm trying to break them up into digestible pieces. :) (In reply to comment #2) > While "message tracing" is a term we use for this, I don't think it's descriptive enough to use within WebKit and WebCore. Something like "diagnostic event recording" would be more descriptive of what it does. Fair point, but "event" is a pretty overloaded term already in WebCore, whereas "trace/tracing" isn't. Perhaps "diagnostic tracing"? "Diagnostic logging"? Created attachment 154658 [details]
Patch
Renamed everything "diagnostic logging".
Committed r123775: <http://trac.webkit.org/changeset/123775> |