Summary: | Unify JSC date and time formating functions | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||||||
Component: | JavaScriptCore | Assignee: | Patrick R. Gansterer <paroga> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ggaren, rniwa, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 91936 | ||||||||||||
Attachments: |
|
Description
Patrick R. Gansterer
2012-07-25 12:56:16 PDT
Created attachment 154421 [details]
Patch
Comment on attachment 154421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review > Source/JavaScriptCore/runtime/DateConversion.cpp:-2 > /* > - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org) This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable. > Source/JavaScriptCore/runtime/DateConversion.h:-2 > /* > - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org) Ditto. Created attachment 154578 [details] Patch (manually edited) (In reply to comment #2) > (From update of attachment 154421 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review > > > Source/JavaScriptCore/runtime/DateConversion.cpp:-2 > > /* > > - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org) > > This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable. I don't think that I'll ever use svn again, since i switched to git. > > Source/JavaScriptCore/runtime/DateConversion.h:-2 > > /* > > - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org) > > Ditto. IMHO the header changes should be easy enough to review. (In reply to comment #3) > Created an attachment (id=154578) [details] > Patch (manually edited) > > (In reply to comment #2) > > (From update of attachment 154421 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review > > > > > Source/JavaScriptCore/runtime/DateConversion.cpp:-2 > > > /* > > > - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org) > > > > This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable. Okay. No problem. Please ask someone else to review it. By the way, regardless of whether it's hard to review or not, someone needs to fix the patch before landing it since we're adding new files, not moving the file & modifying it. That's a misrepresentation of what's happening here. Comment on attachment 154578 [details]
Patch (manually edited)
r=me
Created attachment 156521 [details]
Patch (manually edited)
There was a problem with years out of the range 0-9999.
Created attachment 156522 [details] Interdiff Difference between the last patch, since https://bugs.webkit.org/attachment.cgi?oldid=154578&action=interdiff&newid=156521 does not seam to work. Comment on attachment 156521 [details]
Patch (manually edited)
r=me
Comment on attachment 156521 [details] Patch (manually edited) Clearing flags on attachment: 156521 Committed r124817: <http://trac.webkit.org/changeset/124817> All reviewed patches have been landed. Closing bug. |