Bug 92282

Summary: Unify JSC date and time formating functions
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: JavaScriptCoreAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 91936    
Attachments:
Description Flags
Patch
none
Patch (manually edited)
ggaren: review+
Patch (manually edited)
none
Interdiff none

Description Patrick R. Gansterer 2012-07-25 12:56:16 PDT
Unify JSC date and time formating functions
Comment 1 Patrick R. Gansterer 2012-07-25 13:02:19 PDT
Created attachment 154421 [details]
Patch
Comment 2 Ryosuke Niwa 2012-07-25 23:57:08 PDT
Comment on attachment 154421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review

> Source/JavaScriptCore/runtime/DateConversion.cpp:-2
>  /*
> - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org)

This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable.

> Source/JavaScriptCore/runtime/DateConversion.h:-2
>  /*
> - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org)

Ditto.
Comment 3 Patrick R. Gansterer 2012-07-26 01:47:16 PDT
Created attachment 154578 [details]
Patch (manually edited)

(In reply to comment #2)
> (From update of attachment 154421 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review
> 
> > Source/JavaScriptCore/runtime/DateConversion.cpp:-2
> >  /*
> > - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
> 
> This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable.

I don't think that I'll ever use svn again, since i switched to git.

> > Source/JavaScriptCore/runtime/DateConversion.h:-2
> >  /*
> > - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
> 
> Ditto.

IMHO the header changes should be easy enough to review.
Comment 4 Ryosuke Niwa 2012-07-26 10:43:04 PDT
(In reply to comment #3)
> Created an attachment (id=154578) [details]
> Patch (manually edited)
> 
> (In reply to comment #2)
> > (From update of attachment 154421 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=154421&action=review
> > 
> > > Source/JavaScriptCore/runtime/DateConversion.cpp:-2
> > >  /*
> > > - * Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
> > 
> > This entire file's diff is messed up because of the way git figures out the move. Please use svn or manually edit the patch so that the diff is readable.

Okay. No problem. Please ask someone else to review it.
Comment 5 Ryosuke Niwa 2012-07-26 10:44:22 PDT
By the way, regardless of whether it's hard to review or not, someone needs to fix the patch before landing it since we're adding new files, not moving the file & modifying it. That's a misrepresentation of what's happening here.
Comment 6 Geoffrey Garen 2012-08-01 12:12:21 PDT
Comment on attachment 154578 [details]
Patch (manually edited)

r=me
Comment 7 Patrick R. Gansterer 2012-08-04 00:09:06 PDT
Created attachment 156521 [details]
Patch (manually edited)

There was a problem with years out of the range 0-9999.
Comment 8 Patrick R. Gansterer 2012-08-04 00:22:34 PDT
Created attachment 156522 [details]
Interdiff

Difference between the last patch, since https://bugs.webkit.org/attachment.cgi?oldid=154578&action=interdiff&newid=156521 does not seam to work.
Comment 9 Geoffrey Garen 2012-08-06 16:31:30 PDT
Comment on attachment 156521 [details]
Patch (manually edited)

r=me
Comment 10 WebKit Review Bot 2012-08-06 16:46:26 PDT
Comment on attachment 156521 [details]
Patch (manually edited)

Clearing flags on attachment: 156521

Committed r124817: <http://trac.webkit.org/changeset/124817>
Comment 11 WebKit Review Bot 2012-08-06 16:46:30 PDT
All reviewed patches have been landed.  Closing bug.