Bug 92206

Summary:

[Tests] Re-factor fast/forms/number/number-spinbutton-change-and-input-events.html

Product:

WebKit

Reporter:

yosin

Component:

Tools / Tests

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

92208, 92209

Bug Blocks:

91805

Attachments:

Description	Flags
Patch 1	none
Patch 2	none
Patch 3	none

yosin

Reported 2012-07-24 22:04:00 PDT

We would like to share JavaScript code of number-spinbutton-change-and-input-events.html with other input types.

Attachments
Patch 1 (8.50 KB, patch) 2012-07-25 02:23 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 2 (8.88 KB, patch) 2012-07-25 18:43 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 3 (8.88 KB, patch) 2012-07-25 18:47 PDT, yosin	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

yosin

Comment 1 2012-07-25 02:23:33 PDT

Created attachment 154300 [details] Patch 1

yosin

Comment 2 2012-07-25 02:24:36 PDT

Comment on attachment 154300 [details] Patch 1 Could you review this patch? Thanks in advance.

Kent Tamura

Comment 3 2012-07-25 04:35:32 PDT

Comment on attachment 154300 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=154300&action=review > LayoutTests/ChangeLog:9 > + This patch removes JavaScript codes from test HTML file and changes > + JavaScript code for sharing code with othr input types. You need to explain why you'd like to change so in ChangeLog. The benefit of this change is unclear.

yosin

Comment 4 2012-07-25 18:43:08 PDT

Created attachment 154512 [details] Patch 2

yosin

Comment 5 2012-07-25 18:45:22 PDT

Comment on attachment 154512 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Add explanation why this change is beneficial into ChangeLog

yosin

Comment 6 2012-07-25 18:47:39 PDT

Created attachment 154513 [details] Patch 3

yosin

Comment 7 2012-07-25 18:49:41 PDT

Comment on attachment 154513 [details] Patch 3 Could you review this patch? Thanks in advance. = Changes since the last review = * Add explanation why this change is beneficial into ChangeLog * Revert unexpected parameter change of eventSender.mouseMoveTo, I used "-5" for some experiment.

Kent Tamura

Comment 8 2012-07-25 19:00:57 PDT

Comment on attachment 154513 [details] Patch 3 ok

yosin

Comment 9 2012-07-25 19:06:04 PDT

Comment on attachment 154513 [details] Patch 3 Clearing flags on attachment: 154513 Committed r123692: <http://trac.webkit.org/changeset/123692>

yosin

Comment 10 2012-07-25 19:06:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.