Bug 92209 - [Tests] Copy fast/forms/number/number-spinbutton-change-and-input-events.html to fast/forms/js/resources
Summary: [Tests] Copy fast/forms/number/number-spinbutton-change-and-input-events.html...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 92206
  Show dependency treegraph
 
Reported: 2012-07-24 22:22 PDT by yosin
Modified: 2012-07-24 22:54 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.90 KB, patch)
2012-07-24 22:30 PDT, yosin
no flags Details | Formatted Diff | Diff
Patch (3.34 KB, patch)
2012-07-24 22:47 PDT, yosin
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-07-24 22:22:27 PDT
I would like to re-factor fast/forms/number/number-spinbutton-change-and-input-events.html to share JavaScript code with other input types.

This bug is preparation of this re-factoring and copy two HTML files into JavaScript code directory (fast/forms/resources) as JavaScript code files.
Comment 1 yosin 2012-07-24 22:30:16 PDT
Created attachment 154255 [details]
Patch
Comment 2 yosin 2012-07-24 22:30:51 PDT
Comment on attachment 154255 [details]
Patch

Could you review this patch?
Thanks in advance.

Note: The "Diff" is a result of "svn copy" command.
Comment 3 Kent Tamura 2012-07-24 22:36:26 PDT
Comment on attachment 154255 [details]
Patch

please check what you upload.
Comment 4 yosin 2012-07-24 22:47:39 PDT
Created attachment 154258 [details]
Patch
Comment 5 yosin 2012-07-24 22:48:34 PDT
Comment on attachment 154258 [details]
Patch

Oops, sorry for broken ChangeLog.

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Remove garbage from ChangeLog
Comment 6 Kent Tamura 2012-07-24 22:52:39 PDT
Comment on attachment 154258 [details]
Patch

ok
Comment 7 yosin 2012-07-24 22:54:08 PDT
Landed: r123578