Bug 92083

Summary:

[Tests] Copy fast/forms/number/number-change-type-on-focus.html and number-losing-renderer-on-click.html to fast/forms/resources

Product:

WebKit

Reporter:

yosin

Component:

Tools / Tests

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

92085

Bug Blocks:

92081

Attachments:

Description	Flags
Patch 1	none
Patch 2	tkent: review+

yosin

Reported 2012-07-24 01:51:45 PDT

I would like to re-factor fast/forms/number/number-change-type-on-focus.html and number-crash.html to share JavaScript code with other input types. This bug is preparation of this re-factoring and copy two HTML files into JavaScript code directory (fast/forms/resources) as JavaScript code files.

Attachments
Patch 1 (4.13 KB, patch) 2012-07-24 02:07 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 2 (4.36 KB, patch) 2012-07-24 02:45 PDT, yosin	tkent: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

yosin

Comment 1 2012-07-24 02:07:26 PDT

Created attachment 153992 [details] Patch 1

yosin

Comment 2 2012-07-24 02:08:35 PDT

Comment on attachment 153992 [details] Patch 1 Could you review this patch? Thanks in advance. The diff is result of "svn copy" command lines. They are copy of original files.

Kent Tamura

Comment 3 2012-07-24 02:12:38 PDT

Comment on attachment 153992 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=153992&action=review > LayoutTests/ChangeLog:11 > + - number-crash.html -> common-crash.js I don't think common-crash.js is an appropriate name. common-losing-renderer-on-click.js?

yosin

Comment 4 2012-07-24 02:42:35 PDT

The test "number-crash.html" was renamed to "number-losing-renderer-on-click.html"

yosin

Comment 5 2012-07-24 02:45:27 PDT

Created attachment 154000 [details] Patch 2

yosin

Comment 6 2012-07-24 02:46:37 PDT

Comment on attachment 154000 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Changed for file name renaming number-crash.html => number-losing-renderer-on-click.html

Kent Tamura

Comment 7 2012-07-24 02:49:48 PDT

Comment on attachment 154000 [details] Patch 2 ok

yosin

Comment 8 2012-07-24 02:52:13 PDT

* Change set is OK http://trac.webkit.org/changeset/123448 * Entries is OK. http://trac.webkit.org/log/trunk/LayoutTests/fast/forms/resources/common-change-type-on-focus.js?rev=123448

Note You need to log in before you can comment on or make changes to this bug.