Bug 92002

Summary:

REGRESSION(r123169): It made fast/js/dfg-inline-arguments-use-from-uninlined-code.html fail on 32 bit platforms

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

79666, 91717

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Description Csaba Osztrogonác 2012-07-23 07:48:54 PDT

Here is the diff on Qt 32 bit:
http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20-%20Qt5-WebKit1/r123334%20%2810075%29/fast/js/dfg-inline-arguments-use-from-uninlined-code-pretty-diff.html

Could you check what happened, please?

Comment 1 Csaba Osztrogonác 2012-07-23 08:08:53 PDT

It is skipped by https://trac.webkit.org/changeset/123338 , please unskip it with the proper fix. Thanks.

Comment 2 Filip Pizlo 2012-07-23 15:34:45 PDT

Created attachment 153876 [details]
the patch

Comment 3 Filip Pizlo 2012-07-23 15:39:09 PDT

Landed in http://trac.webkit.org/changeset/123393.  This changeset also unskips the test.

Comment 4 Csaba Osztrogonác 2012-07-24 03:18:02 PDT

(In reply to comment #3)
> Landed in http://trac.webkit.org/changeset/123393.  This changeset also unskips the test.

Thanks for the quick fix. ;-)