Bug 91717 - DFG cell checks should be hoisted
Summary: DFG cell checks should be hoisted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 92002
Blocks:
  Show dependency tree / graph
 
Reported: 2012-07-18 23:38 PDT by Filip Pizlo
Modified: 2012-07-23 07:48 PDT (History)
6 users (show)

See Also:

Attachments
the patch (13.62 KB, patch)
2012-07-18 23:47 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-07-18 23:38:19 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-07-18 23:47:30 PDT 
Created attachment 153189 [details]
the patch
Comment 2 WebKit Review Bot 2012-07-18 23:51:04 PDT 
Attachment 153189 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/assembler/X86Assembler.h:1000:  testq_rm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2012-07-19 10:51:44 PDT 
Comment on attachment 153189 [details]
the patch

r=me
Comment 4 Filip Pizlo 2012-07-19 20:52:52 PDT 
Landed in http://trac.webkit.org/changeset/123169