| Summary: | [Qt] WebViewLoadFavIcon::test_favIconLoad() fails | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rafael Brandao <rafael.lobo> | ||||||
| Component: | WebKit Qt | Assignee: | Rafael Brandao <rafael.lobo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, menard, ossy, webkit.review.bot, zoltan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 70236 | ||||||||
| Attachments: |
|
||||||||
|
Description
Rafael Brandao
2012-07-20 11:58:27 PDT
Created attachment 153554 [details]
Patch
Comment on attachment 153554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153554&action=review Looks good to me. But I have a question :-) > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:40 > verify(webView.waitForLoadSucceeded()) > + spy.wait() Do we even need to webView.waitForLoadSucceeded here? > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:51 > verify(webView.waitForLoadSucceeded()) > + spy.wait() And here. Created attachment 155374 [details]
Patch
Makes sense. Unfortunately the bug is no longer showing up on my machine because it's now faster and it seems it's neither showing up on buildbot. But for me it's clear that there's a problem there, so I'm all for upstreaming this patch. :-) Comment on attachment 155374 [details] Patch Clearing flags on attachment: 155374 Committed r125291: <http://trac.webkit.org/changeset/125291> All reviewed patches have been landed. Closing bug. |