Bug 91814

Summary: Introduce Node::shadowHost()
Product: WebKit Reporter: Kent Tamura <tkent>
Component: DOMAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91589    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-08
none
Patch 2 morrita: review+

Kent Tamura
Reported 2012-07-19 21:25:37 PDT
Introduce Node::shadowHost(), which return the host element, or 0.
Attachments
Patch (3.45 KB, patch)
2012-07-19 21:41 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-08 (1.30 MB, application/zip)
2012-07-19 22:30 PDT, WebKit Review Bot 		no flags
Details
Patch 2 (3.51 KB, patch)
2012-07-19 22:39 PDT, Kent Tamura 		morrita: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-07-19 21:41:29 PDT
Created attachment 153404 [details] Patch
WebKit Review Bot
Comment 2 2012-07-19 22:30:49 PDT
Comment on attachment 153404 [details] Patch Attachment 153404 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13312126 New failing tests: css3/filters/effect-opacity.html
WebKit Review Bot
Comment 3 2012-07-19 22:30:52 PDT
Created attachment 153411 [details] Archive of layout-test-results from gce-cr-linux-08 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Shinya Kawanaka
Comment 4 2012-07-19 22:34:57 PDT
Comment on attachment 153404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153404&action=review > Source/WebCore/dom/Node.h:228 > + // If this node is in a shadow tree, returns its shadow host. Otherwise, returns this. I think we should mention using shadowAncestorNode() is discouraged. > Source/WebCore/html/shadow/CalendarPickerElement.cpp:85 > + // alwasys in shadow of <input>. s/alwasys/always/
Kent Tamura
Comment 5 2012-07-19 22:39:57 PDT
Created attachment 153417 [details] Patch 2 Improve comments
Kent Tamura
Comment 6 2012-07-19 22:54:51 PDT
Committed r123180: <http://trac.webkit.org/changeset/123180>
Note You need to log in before you can comment on or make changes to this bug.