| Summary: | [Tests] Rename fast/forms/number/*.html to number-*.html | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | yosin | ||||
| Component: | Tools / Tests | Assignee: | yosin | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | atwilson, gyuyoung.kim, rakuco, tkent, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 91805 | ||||||
| Attachments: |
|
||||||
|
Description
yosin
2012-07-19 20:56:03 PDT
Created attachment 153451 [details]
Patch 1
Comment on attachment 153451 [details]
Patch 1
Could you review this patch?
Thanks in advance.
This is result of "svn move". So, I'll commit from terminal.
Will you rename LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton*.html in another patch? (In reply to comment #3) > Will you rename LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton*.html in another patch? It is out of scope of this bug. This bug is intended for renaming files under LayoutTests/fast/form/numbers/. (In reply to comment #3) > Will you rename LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton*.html in another patch? In the future, yes. There are 13 files under LayoutTest/platform/*/fast/forms/. Comment on attachment 153451 [details]
Patch 1
rubber stamped.
Please watch the buildbots for a while after landing this patch.
Renaming is succeeded: 1. Change set displays entries with "moved from" 2. Individual file entry has "copied from", e.g. http://trac.webkit.org/log/trunk/LayoutTests/fast/forms/number/number-size.html?rev=123302 I'm watching "Waterfall" I'm seeing these errors in the webkit lint output: e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:228 Path does not exist. fast/forms/number/input-appearance-number-rtl.html e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:229 Path does not exist. fast/forms/number/input-appearance-spinbutton-disabled-readonly.html e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:230 Path does not exist. fast/forms/number/input-appearance-spinbutton-layer.html (In reply to comment #8) > I'm seeing these errors in the webkit lint output: > > e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:228 Path does not exist. fast/forms/number/input-appearance-number-rtl.html > e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:229 Path does not exist. fast/forms/number/input-appearance-spinbutton-disabled-readonly.html > e:\b\build\slave\Webkit_Win7\build\src\skia\skia_test_expectations.txt:230 Path does not exist. fast/forms/number/input-appearance-spinbutton-layer.html Thanks Andrew! I updates skia_test_expectations.txt http://codereview.chromium.org/10810065 |