Bug 91767

Summary: ColorChooserClient should expose the element's location
Product: WebKit Reporter: Pierre Rossi <pierre.rossi>
Component: New BugsAssignee: Pierre Rossi <pierre.rossi>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, dglazkov, gustavo, gyuyoung.kim, menard, mifenton, mrobinson, tkent, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91664    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Pierre Rossi 2012-07-19 11:52:16 PDT 
ColorChooserClient should expose the element's location
Comment 1 Pierre Rossi 2012-07-19 11:55:51 PDT 
Created attachment 153317 [details]
Patch
Comment 2 Pierre Rossi 2012-07-19 12:06:28 PDT 
Created attachment 153319 [details]
Patch
Comment 3 WebKit Review Bot 2012-07-19 12:08:47 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 WebKit Review Bot 2012-07-19 12:23:57 PDT 
Comment on attachment 153319 [details]
Patch

Attachment 153319 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13274944
Comment 5 Pierre Rossi 2012-07-20 03:25:15 PDT 
Created attachment 153464 [details]
Patch
Comment 6 Kent Tamura 2012-07-20 03:26:46 PDT 
Comment on attachment 153464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153464&action=review

> Source/WebCore/html/ColorInputType.h:37
> +#include "IntRect.h"

IntRect.h should be included in ColorChooserClient.h.
Comment 7 Kent Tamura 2012-07-20 03:28:54 PDT 
Comment on attachment 153464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153464&action=review

> Source/WebCore/html/ColorInputType.cpp:204
> +    return pixelSnappedIntRect(renderer->view()->frameView()->contentsToWindow(renderer->absoluteBoundingBoxRectIgnoringTransforms()));

Why ignoringTransofrms ?
Comment 8 Pierre Rossi 2012-07-20 06:40:48 PDT 
Created attachment 153492 [details]
Patch
Comment 9 Kent Tamura 2012-07-20 06:43:28 PDT 
Comment on attachment 153492 [details]
Patch

Looks good.
Comment 10 WebKit Review Bot 2012-07-20 07:23:55 PDT 
Comment on attachment 153492 [details]
Patch

Clearing flags on attachment: 153492

Committed r123214: <http://trac.webkit.org/changeset/123214>
Comment 11 WebKit Review Bot 2012-07-20 07:24:02 PDT 
All reviewed patches have been landed.  Closing bug.