Bug 91709 – Web Inspector: Enable FileSystem support by default

• Component: Web Inspector (Deprecated)
• Status: RESOLVED INVALID

[Taiju Tsuiki]

All patch for adding basic support of FileSystem has landed, and it seems to work well for me.
So, may I drop its experiments flag and enable FileSystem support by default?

[Taiju Tsuiki]

Created attachment 153170 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 153170 [details]
Patch

We should remove this from Preferences, there is no need to disable file system inspection when it is supported. We should use Capabilities instead on platforms where file system is not supported yet.
Please refer to the earlier Pavel's comment https://bugs.webkit.org/show_bug.cgi?id=72691#c19

[Taiju Tsuiki]

Created attachment 153224 [details]
Patch

[Taiju Tsuiki]

(In reply to comment #2)
> (From update of attachment 153170 [details])
> We should remove this from Preferences, there is no need to disable file system inspection when it is supported. We should use Capabilities instead on platforms where file system is not supported yet.
> Please refer to the earlier Pavel's comment https://bugs.webkit.org/show_bug.cgi?id=72691#c19

I see. I erased Preference.exposeFileSystemInspection and added Capabilities.fileSystemAPISupport.

[Pavel Feldman]

There are changes I'd like to see applied before it leaves experimental:

1) The tree as of today does not scale: it has no scrollers, it would not scale for large trees even with scrollers

I'd suggest that the tree is embedded into the table (a-la Finder) or is converted into a list and embedded into the table (a-la Windows Explorer)

2) We can make preview show to the right from the tree-table for docked to bottom mode and in the bottom part of the screen for undocked / docked-to-right mode.

3) I think it is important to be able to format the file system and remove particular folder for the debugging purposes.

[Taiju Tsuiki]

Created attachment 153438 [details]
Screenshot

[Taiju Tsuiki]

(In reply to comment #5)
> There are changes I'd like to see applied before it leaves experimental:
> 
> 1) The tree as of today does not scale: it has no scrollers, it would not scale for large trees even with scrollers
> 
> I'd suggest that the tree is embedded into the table (a-la Finder) or is converted into a list and embedded into the table (a-la Windows Explorer)
> 

Does adding some navigator help to walk on large tree?
Such as "Navigate to parent/ancestor" button on status bar and navigation by double-clicking on DirectoryContentView.
It is like my favorite Windows Explorer configuration.

> 2) We can make preview show to the right from the tree-table for docked to bottom mode and in the bottom part of the screen for undocked / docked-to-right mode.
> 

Is FileContentView too narrow horizontally for undocked mode?
How about adding a button to hide directory tree?
It will widen {File,Directory}ContentView as same width as other resource preview.

> 3) I think it is important to be able to format the file system and remove particular folder for the debugging purposes.

I agree it is important for debugging, but I thought it can be done incrementally.
OK for rising its priority.

[Pavel Feldman]

> Does adding some navigator help to walk on large tree?
> Such as "Navigate to parent/ancestor" button on status bar and navigation by double-clicking on DirectoryContentView.
> It is like my favorite Windows Explorer configuration.

It would be great to see the crumbs (a-la Windows Explorer or bottom of Elements panel).

> Is FileContentView too narrow horizontally for undocked mode?
> How about adding a button to hide directory tree?
> It will widen {File,Directory}ContentView as same width as other resource preview.
> 

I don't think we need a tree. Windows Explorer does not have it.

> I agree it is important for debugging, but I thought it can be done incrementally.
> OK for rising its priority.

Incrementally sounds good, but we should not go out of experimental until basic features are there. I think these two are the most important.

[Vsevolod Vlasov]

Comment on attachment 153224 [details]
Patch

Clearing r? for now per Pavel's comments.

[Taiju Tsuiki]

Created attachment 158997 [details]
Whiteboard prototype, ResourcesPanel to FileSystemView

[Taiju Tsuiki]

Created attachment 158998 [details]
Whiteboard prototype, FileSystemView to {File,Directory}ContentView

[Taiju Tsuiki]

Created attachment 159000 [details]
Whiteboard prototype, FileSystemVie

[Taiju Tsuiki]

I'm refining UI for FileSystemView as attached whiteboard prototype.
Diffs to current version are:
 - Adding "Delete" button,
 - Removing directory tree, so that {File,Directory}ContentView is goint to be main view of FileSystemView,
 - Adding Breadcrumb list to status bar.

Any suggestion at this stage?

[Taiju Tsuiki]

Created attachment 159008 [details]
Screenshot

+another screenshot of local build.
Adding crumbs like this.

[Yury Semikhatsky]

(In reply to comment #14)
> Created an attachment (id=159008) [details]
> Screenshot
> 
> +another screenshot of local build.
> Adding crumbs like this.

I'm a bit confused as the screenshot contains separate directory tree which is missing on the whiteboard. I'm personally for removing separate directory tree and making the directory view more like in Finder on Mac OS X or Nautilus in Gnome. You can always step up using the crumbs and step down by either expanding a directory or stepping into it via double-click. The separate tree just clutters the UI with duplicate data.

[Taiju Tsuiki]

(In reply to comment #15)
> (In reply to comment #14)
> > Created an attachment (id=159008) [details] [details]
> > Screenshot
> > 
> > +another screenshot of local build.
> > Adding crumbs like this.
> 
> I'm a bit confused as the screenshot contains separate directory tree which is missing on the whiteboard. I'm personally for removing separate directory tree and making the directory view more like in Finder on Mac OS X or Nautilus in Gnome. You can always step up using the crumbs and step down by either expanding a directory or stepping into it via double-click. The separate tree just clutters the UI with duplicate data.

Ah, sorry for confusing screenshot.
I'm implementing it like whiteboard sketch without directory tree but not yet removed directory tree. It'll be removed soon later.
I meant to show how crumbs looks like, by the screenshot.

[Brian Burg]

This feature is no longer in WebKit.