Bug 94908 – Web Inspector: Remove directory tree from FileSystemView and add item-based navigation.

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Taiju Tsuiki]

Per discussion on http://webkit.org/b/91709 ,
I'm removing directory tree from FileSystemView and adding navigation by double-clicking in main view.

[Taiju Tsuiki]

Created attachment 160351 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160351 [details]
Patch

Attachment 160351 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13595121

New failing tests:
http/tests/inspector/filesystem/directory-tree.html

[WebKit Review Bot]

Created attachment 160389 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Taiju Tsuiki]

Created attachment 162158 [details]
Patch

[Taiju Tsuiki]

Created attachment 162469 [details]
Patch

[WebKit Review Bot]

Comment on attachment 162469 [details]
Patch

Attachment 162469 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13774611

New failing tests:
http/tests/inspector/filesystem/ui/directory-content-view.html

[Vsevolod Vlasov]

Comment on attachment 162469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162469&action=review

> Source/WebCore/inspector/front-end/FileSystemView.js:48
> +    this._navigateUpButton = new WebInspector.StatusBarButton(WebInspector.UIString("Go up to parent directory"), "navigate-up-status-bar-item");

This one was not present on the mocks and I don't really like it. We already have crumbs for this right there, we should probably add a ".." directory to the list instead.
Could you please provide a screenshot and some motivation?

[Taiju Tsuiki]

Created attachment 163133 [details]
Rebase and test fix

[Taiju Tsuiki]

Created attachment 163136 [details]
Screenshot

[Taiju Tsuiki]

(In reply to comment #7)
> (From update of attachment 162469 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162469&action=review
> 
> > Source/WebCore/inspector/front-end/FileSystemView.js:48
> > +    this._navigateUpButton = new WebInspector.StatusBarButton(WebInspector.UIString("Go up to parent directory"), "navigate-up-status-bar-item");
> 
> This one was not present on the mocks and I don't really like it. We already have crumbs for this right there, we should probably add a ".." directory to the list instead.
> Could you please provide a screenshot and some motivation?

Yes, this is not on mock.
Actually, I've not put crumbs in this patch, will put in next one.
As the motivation for adding "up to parent directory" button, there's no way to close opened file or directory, so I think we need a button to go to parent director until the crumb UI lands.

".." directory seems to work for going to parent directory from a directory, but we still need a button for closing file.

[Vsevolod Vlasov]

> As the motivation for adding "up to parent directory" button, there's no way to close opened file or directory, so I think we need a button to go to parent director until the crumb UI lands.
This button looks ugly.
Instead of making it look prettier I suggest landing crumbs first.

> 
> ".." directory seems to work for going to parent directory from a directory, but we still need a button for closing file.
We can still use bread crumbs for that, aren't we?

[Brian Burg]

This feature is no longer in WebKit.