Bug 91664

Summary:

[WK2] expose element rect for color input type

Product:

WebKit

Reporter:

Pierre Rossi <pierre.rossi>

Component:

New Bugs

Assignee:

Pierre Rossi <pierre.rossi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, cgarcia, cmarcelo, dglazkov, gustavo, gyuyoung.kim, keishi, menard, mifenton, mrobinson, rakuco, sw0524.lee, tkent, webkit.review.bot, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

91767

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Pierre Rossi

Reported 2012-07-18 13:41:06 PDT

[Qt][WK2] expose element rect for color input type

Attachments
Patch (24.72 KB, patch) 2012-07-18 14:18 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (21.53 KB, patch) 2012-07-20 06:42 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (21.48 KB, patch) 2012-07-20 08:36 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (21.48 KB, patch) 2012-09-07 12:59 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Pierre Rossi

Comment 1 2012-07-18 14:18:22 PDT

Created attachment 153085 [details] Patch

WebKit Review Bot

Comment 2 2012-07-18 14:21:48 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Alexis Menard (darktears)

Comment 3 2012-07-18 14:32:53 PDT

Comment on attachment 153085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review > Source/WebCore/ChangeLog:3 > + [Qt][WK2] expose element rect for color input type You should rename the bug. You modify other files than Qt so [Qt] is not correct here.

WebKit Review Bot

Comment 4 2012-07-18 14:37:45 PDT

Comment on attachment 153085 [details] Patch Attachment 153085 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13271715

Kent Tamura

Comment 5 2012-07-18 16:35:01 PDT

Comment on attachment 153085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review You had better split the patch into the WebCore part and the WebKit2 part. > Source/WebCore/platform/ColorChooserClient.h:20 > + virtual IntRect elementRect() const = 0; Need a comment about rect in what; in frame? in RootView? in window? in screen? Or rename the function like elementRectInWindow()

Pierre Rossi

Comment 6 2012-07-20 06:42:13 PDT

Created attachment 153493 [details] Patch

Gyuyoung Kim

Comment 7 2012-07-20 06:49:43 PDT

Comment on attachment 153493 [details] Patch Attachment 153493 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13318067

Early Warning System Bot

Comment 8 2012-07-20 07:07:27 PDT

Comment on attachment 153493 [details] Patch Attachment 153493 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13308282

Pierre Rossi

Comment 9 2012-07-20 08:35:07 PDT

Comment on attachment 153493 [details] Patch Was a bit hasty in updating this patch before the commit-queue landed r123214.