Summary: | [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Jansa <Martin.Jansa> | ||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, gustavo, gyuyoung.kim, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tmpsantos, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Martin Jansa
2012-07-18 07:34:08 PDT
Created attachment 153011 [details] OptionsEfl: bump libsoup requirements like autotools did in r121772 LGTM (In reply to comment #2) > LGTM But you have to write a changelog. :) Comment on attachment 153011 [details] OptionsEfl: bump libsoup requirements like autotools did in r121772 View in context: https://bugs.webkit.org/attachment.cgi?id=153011&action=review I'm in the middle of something but I can take over this patch soon if needed. > Source/cmake/OptionsEfl.cmake:38 > +FIND_PACKAGE(LibSoup2 2.39.2 REQUIRED) We actually need 2.39.3. Created attachment 153062 [details] Patch The first tarball to contain the API we need is definitely v2.39.3 (not 2.39.2) although the version tag in GIT to contain the API is LIBSOUP_2_39_2 (Misleading): - http://ftp.acc.umu.se/pub/gnome/sources/libsoup/2.39/libsoup-2.39.3.news (Second bullet) I bumped the dependency in CMake and I also had to update our jhbuild config to pull in the v2.39.3 tarball as well since the GIT tag we where using was still versioned 2.39.2. This way we match the CMake requirements. Comment on attachment 153062 [details]
Patch
Looks good, thanks for looking at this.
LGTM. Thanks Christophe! Comment on attachment 153062 [details] Patch Clearing flags on attachment: 153062 Committed r123069: <http://trac.webkit.org/changeset/123069> All reviewed patches have been landed. Closing bug. |