Bug 91626

Summary: [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild
Product: WebKit Reporter: Martin Jansa <Martin.Jansa>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gustavo, gyuyoung.kim, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tmpsantos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
OptionsEfl: bump libsoup requirements like autotools did in r121772
none
Patch none

Martin Jansa
Reported 2012-07-18 07:34:08 PDT
GTK version was bumped in https://bugs.webkit.org/show_bug.cgi?id=90332, but EFL is using cmake so bump it there too.
Attachments
OptionsEfl: bump libsoup requirements like autotools did in r121772 (1.70 KB, patch)
2012-07-18 07:35 PDT, Martin Jansa 		no flags
DetailsFormatted DiffDiff
Patch (2.59 KB, patch)
2012-07-18 11:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Jansa
Comment 1 2012-07-18 07:35:11 PDT
Created attachment 153011 [details] OptionsEfl: bump libsoup requirements like autotools did in r121772
Thiago Marcos P. Santos
Comment 2 2012-07-18 07:35:51 PDT
LGTM
Thiago Marcos P. Santos
Comment 3 2012-07-18 07:36:09 PDT
(In reply to comment #2) > LGTM But you have to write a changelog. :)
Chris Dumez
Comment 4 2012-07-18 09:16:00 PDT
Comment on attachment 153011 [details] OptionsEfl: bump libsoup requirements like autotools did in r121772 View in context: https://bugs.webkit.org/attachment.cgi?id=153011&action=review I'm in the middle of something but I can take over this patch soon if needed. > Source/cmake/OptionsEfl.cmake:38 > +FIND_PACKAGE(LibSoup2 2.39.2 REQUIRED) We actually need 2.39.3.
Chris Dumez
Comment 5 2012-07-18 11:46:04 PDT
Created attachment 153062 [details] Patch The first tarball to contain the API we need is definitely v2.39.3 (not 2.39.2) although the version tag in GIT to contain the API is LIBSOUP_2_39_2 (Misleading): - http://ftp.acc.umu.se/pub/gnome/sources/libsoup/2.39/libsoup-2.39.3.news (Second bullet) I bumped the dependency in CMake and I also had to update our jhbuild config to pull in the v2.39.3 tarball as well since the GIT tag we where using was still versioned 2.39.2. This way we match the CMake requirements.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-07-18 13:03:04 PDT
Comment on attachment 153062 [details] Patch Looks good, thanks for looking at this.
Thiago Marcos P. Santos
Comment 7 2012-07-18 13:08:56 PDT
LGTM. Thanks Christophe!
WebKit Review Bot
Comment 8 2012-07-18 21:48:10 PDT
Comment on attachment 153062 [details] Patch Clearing flags on attachment: 153062 Committed r123069: <http://trac.webkit.org/changeset/123069>
WebKit Review Bot
Comment 9 2012-07-18 21:48:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.