Bug 91486

Summary: A shadow element in ShadowDOM of a button element does not work.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: cletusw+webkit, cmarcelo, dglazkov, gustavo, mifenton, philn, tkent, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82313    
Attachments:
Description Flags
WIP
none
Patch
none
Archive of layout-test-results from gce-cr-linux-07
none
Patch
none
Patch for landing none

Description Shinya Kawanaka 2012-07-17 03:59:38 PDT 
When we add an AuthorShadowDOM to button element, it should be rendered correctly.
Comment 1 Shinya Kawanaka 2012-08-14 19:50:34 PDT 
Created attachment 158485 [details]
WIP
Comment 2 WebKit Review Bot 2012-08-14 20:26:14 PDT 
Attachment 158485 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/WebCore/html/HTMLButtonElement.cpp:48:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-08-14 20:31:40 PDT 
Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13510024
Comment 4 Build Bot 2012-08-14 20:47:31 PDT 
Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13501489
Comment 5 Gyuyoung Kim 2012-08-14 20:59:49 PDT 
Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13490869
Comment 6 Early Warning System Bot 2012-08-14 21:12:14 PDT 
Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13510037
Comment 7 Early Warning System Bot 2012-08-14 21:29:26 PDT 
Comment on attachment 158485 [details]
WIP

Attachment 158485 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13503500
Comment 8 Shinya Kawanaka 2012-08-20 21:43:04 PDT 
Created attachment 159617 [details]
Patch
Comment 9 WebKit Review Bot 2012-08-20 22:35:15 PDT 
Comment on attachment 159617 [details]
Patch

Attachment 159617 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13546274

New failing tests:
fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html
Comment 10 WebKit Review Bot 2012-08-20 22:35:19 PDT 
Created attachment 159623 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 11 Shinya Kawanaka 2012-08-21 05:01:05 PDT 
Created attachment 159660 [details]
Patch
Comment 12 Dimitri Glazkov (Google) 2012-08-21 11:46:28 PDT 
Comment on attachment 159660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159660&action=review

> Source/WebCore/ChangeLog:10
> +        So we have to prevent from creating UserAgentShadowDOM.

... prevent it from ...
Comment 13 Shinya Kawanaka 2012-08-21 17:40:14 PDT 
Created attachment 159816 [details]
Patch for landing
Comment 14 WebKit Review Bot 2012-08-21 18:46:57 PDT 
Comment on attachment 159816 [details]
Patch for landing

Clearing flags on attachment: 159816

Committed r126248: <http://trac.webkit.org/changeset/126248>
Comment 15 WebKit Review Bot 2012-08-21 18:47:01 PDT 
All reviewed patches have been landed.  Closing bug.