Summary: | [Qt] platform/qt/editing/pasteboard tests needs update after rebaseline and new testfonts (75) | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ádám Kallai <kadam> | ||||||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | cmarcelo, hausmann, kkristof, ossy, szledan, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 85203 | ||||||||||||||||
Attachments: |
|
Description
Ádám Kallai
2012-07-16 09:06:35 PDT
Created attachment 152549 [details]
proposed patch
I updated test expectations and png. I skipped a failing test.
Did you forget to set r? Fixing typo in the bug title. Sorry, I forgot to set r?. I'll fix it. Created attachment 153778 [details]
proposed patch
Update last patch.
Comment on attachment 153778 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=153778&action=review > LayoutTests/platform/qt-5.0/Skipped:1552 > +editing/pasteboard/4944770-1.html > +editing/pasteboard/4944770-2.html Are these two still failing? They seem to work here. It's very interesting. These tests wasn't working, when I tested them therefore I left them on skippedlist. I'm going to testing again. Maybe I was inattentive. You were right. :) Thanks for the review. I was inattentive. :( I added new expectations to platform/qt but these tests had some older expectations in qt-5.0-wk2 and qt-5.0 too. When I was testing it the script didn't consider platform/qt baseline directory. Those expectations will be deleted and it will work fine. Created attachment 154023 [details]
proposed patch
I updated my patch. Now these tests are working well.
Created attachment 154343 [details]
proposed patch
I think patch is ready. I hope it's working now. Could you have look at it please?
Comment on attachment 154343 [details]
proposed patch
rs=me
Comment on attachment 154343 [details] proposed patch Rejecting attachment 154343 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s/platform/qt/editing/pasteboard/smart-paste-007-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/styled-element-markup-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/unrendered-br-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13341254 Maybe the patch needs to be rebased? Created attachment 154663 [details]
proposed patch
I'm ready to update.
Comment on attachment 154663 [details] proposed patch Rejecting attachment 154663 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ed.txt patching file LayoutTests/platform/qt/editing/pasteboard/smart-paste-007-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/styled-element-markup-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/unrendered-br-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13349870 Created attachment 154856 [details]
proposed patch
Update.
Comment on attachment 154856 [details] proposed patch Rejecting attachment 154856 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13361989 Comment on attachment 154856 [details] proposed patch Clearing flags on attachment: 154856 Committed r123862: <http://trac.webkit.org/changeset/123862> All reviewed patches have been landed. Closing bug. |