Bug 91234

Summary: [Qt] compositing tests need rebaseline with new testfonts
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85203    
Attachments:
Description Flags
patch kbalazs: commit-queue-

Balazs Kelemen
Reported 2012-07-13 06:34:56 PDT
Oh, yeah
Attachments
patch (1.48 MB, patch)
2012-07-13 08:28 PDT, Balazs Kelemen 		kbalazs: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2012-07-13 08:28:25 PDT
Created attachment 152267 [details] patch I'm a bit confused. The tar Ossy created contained expectations in the generic platform/qt directory that are not exist currently. I checked Ossy's results with the rebaseline-server and every result was good. However, after I unskip the tests I still have font differences locally - a few with WebKit2 (13) and more with WebKit1 (34). Anyway I'm uploading this as I really curios whether I did what Ossy was planning or I did something wrong. The patch also contains pixel results because all of them was good too, so snapshot pixels (bug 90394) should be the same. Anyway, we should double-check this test (probably on bots) before checking in.
Balazs Kelemen
Comment 2 2012-07-16 05:14:05 PDT
Comment on attachment 152267 [details] patch Just baseline update, don't need review.
Balazs Kelemen
Comment 3 2012-07-16 07:32:41 PDT
Landed in http://trac.webkit.org/changeset/122722
Note You need to log in before you can comment on or make changes to this bug.