Bug 91031

Summary:

[V8] Enable es5_readonly

Product:

WebKit

Reporter:

Erik Arvidsson <arv>

Component:

New Bugs

Assignee:

Erik Arvidsson <arv>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric.carlson, feature-media-reviews, haraken, japhet, jochen, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

91668, 93543, 93555

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from gce-cr-linux-07	none
Patch	none
Archive of layout-test-results from gce-cr-linux-01	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Archive of layout-test-results from gce-cr-linux-07	none
Patch	none
Archive of layout-test-results from gce-cr-linux-06	none
Patch	none
Patch	none

Erik Arvidsson

Reported 2012-07-11 15:51:43 PDT

[V8] Enable es5_readonly

Attachments
Patch (2.45 KB, patch) 2012-07-11 15:52 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-07 (376.90 KB, application/zip) 2012-07-11 17:15 PDT, WebKit Review Bot	no flags	Details
Patch (63.74 KB, patch) 2012-07-16 16:13 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-01 (379.62 KB, application/zip) 2012-07-16 18:03 PDT, WebKit Review Bot	no flags	Details
Patch (63.42 KB, patch) 2012-07-17 12:29 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Patch (2.71 KB, patch) 2012-07-19 14:53 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Patch (2.68 KB, patch) 2012-07-19 15:35 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Patch for landing (2.69 KB, patch) 2012-07-30 11:51 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-07 (374.38 KB, application/zip) 2012-07-31 01:23 PDT, WebKit Review Bot	no flags	Details
Patch (5.67 KB, patch) 2012-08-07 18:22 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-06 (390.89 KB, application/zip) 2012-08-08 12:48 PDT, WebKit Review Bot	no flags	Details
Patch (8.14 KB, patch) 2012-08-09 12:20 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Patch (4.42 KB, patch) 2012-08-09 19:47 PDT, Erik Arvidsson	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Erik Arvidsson

Comment 1 2012-07-11 15:52:46 PDT

Created attachment 151807 [details] Patch

WebKit Review Bot

Comment 2 2012-07-11 17:15:04 PDT

Comment on attachment 151807 [details] Patch Attachment 151807 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13198573 New failing tests: http/tests/media/reload-after-dialog.html editing/selection/5195166-1.html editing/spelling/spelling-unified-emulation.html editing/text-iterator/first-letter-word-boundary.html editing/selection/5213963.html http/tests/appcache/video.html editing/deleting/4922367.html editing/selection/5209984.html editing/undo/replace-by-span-then-remove.html css3/calc/border.html editing/spelling/spelling-attribute-change.html http/tests/media/pdf-served-as-pdf.html css3/calc/padding.html editing/spelling/spelling-hasspellingmarker.html editing/selection/modify-up-on-rtl-wrapping-text.html editing/selection/click-left-of-rtl-wrapping-text.html http/tests/media/text-served-as-text.html css3/filters/blur-filter-page-scroll-self.html editing/execCommand/5939887.html http/tests/media/video-error-abort.html http/tests/media/remove-while-loading.html http/tests/media/media-document.html css3/calc/table-border-spacing.html http/tests/media/video-cookie.html http/tests/media/video-load-twice.html

WebKit Review Bot

Comment 3 2012-07-11 17:15:08 PDT

Created attachment 151818 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Erik Arvidsson

Comment 4 2012-07-16 16:13:53 PDT

Created attachment 152638 [details] Patch

WebKit Review Bot

Comment 5 2012-07-16 18:03:52 PDT

Comment on attachment 152638 [details] Patch Attachment 152638 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13261165 New failing tests: http/tests/security/inactive-document-with-empty-security-origin.html

WebKit Review Bot

Comment 6 2012-07-16 18:03:56 PDT

Created attachment 152663 [details] Archive of layout-test-results from gce-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Erik Arvidsson

Comment 7 2012-07-17 12:29:45 PDT

Created attachment 152805 [details] Patch

Erik Arvidsson

Comment 8 2012-07-19 14:53:12 PDT

Created attachment 153352 [details] Patch

WebKit Review Bot

Comment 9 2012-07-19 15:28:51 PDT

Comment on attachment 153352 [details] Patch Attachment 153352 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13309037

Erik Arvidsson

Comment 10 2012-07-19 15:35:31 PDT

Created attachment 153363 [details] Patch

WebKit Review Bot

Comment 11 2012-07-19 15:41:37 PDT

Comment on attachment 153363 [details] Patch Attachment 153363 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13303097

Adam Barth

Comment 12 2012-07-27 02:06:49 PDT

Comment on attachment 153363 [details] Patch rs=me, assuming this lands cleanly.

Erik Arvidsson

Comment 13 2012-07-30 11:51:37 PDT

Created attachment 155332 [details] Patch for landing

Erik Arvidsson

Comment 14 2012-07-30 18:02:45 PDT

Comment on attachment 155332 [details] Patch for landing This is going to fail again. This exposes another V8 binding bug related to [DoNotCheckSecurity]

WebKit Review Bot

Comment 15 2012-07-31 01:23:18 PDT

Comment on attachment 155332 [details] Patch for landing Attachment 155332 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13389595 New failing tests: fast/dom/Window/get-set-properties.html media/network-no-source-const-shadow.html fast/js/toString-and-valueOf-override.html

WebKit Review Bot

Comment 16 2012-07-31 01:23:23 PDT

Created attachment 155463 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Erik Arvidsson

Comment 17 2012-08-07 18:22:51 PDT

Created attachment 157073 [details] Patch

WebKit Review Bot

Comment 18 2012-08-08 12:48:09 PDT

Comment on attachment 157073 [details] Patch Attachment 157073 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13460272 New failing tests: media/network-no-source-const-shadow.html

WebKit Review Bot

Comment 19 2012-08-08 12:48:13 PDT

Created attachment 157272 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Erik Arvidsson

Comment 20 2012-08-09 12:20:27 PDT

Created attachment 157512 [details] Patch

Erik Arvidsson

Comment 21 2012-08-09 19:47:11 PDT

Created attachment 157616 [details] Patch

Adam Barth

Comment 22 2012-08-10 09:36:52 PDT

congrats

WebKit Review Bot

Comment 23 2012-08-10 10:05:27 PDT

Comment on attachment 157616 [details] Patch Clearing flags on attachment: 157616 Committed r125296: <http://trac.webkit.org/changeset/125296>

WebKit Review Bot

Comment 24 2012-08-10 10:05:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.