Summary: | [WK2][EFL] Add policy client to Ewk_View | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gustavo, gyuyoung.kim, kenneth, rakuco, ryuan.choi, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 61838 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2012-07-11 01:51:15 PDT
Created attachment 151691 [details]
Patch
Comment on attachment 151691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151691&action=review > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:44 > + bool madePolicyDecision; isnt it more like it is accepted? "didAccept"? > Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.h:46 > + EWK_NAVIGATION_TYPE_LINK_CLICKED, I prefer LINK_ACTIVATED especially since it covers a linked being tapped by a finger Comment on attachment 151691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151691&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:44 >> + bool madePolicyDecision; > > isnt it more like it is accepted? "didAccept"? No, we want to know if "any" decision was made by the client (accept, reject or download). This is needed, to make a default policy decision ("accept" in this patch) in the case the client did not make an explicit decision. >> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.h:46 >> + EWK_NAVIGATION_TYPE_LINK_CLICKED, > > I prefer LINK_ACTIVATED especially since it covers a linked being tapped by a finger Good point. I will fix this and reupload. Created attachment 151871 [details]
Patch
Take Kenneth's feedback into consideration.
(In reply to comment #3) > (From update of attachment 151691 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151691&action=review > > >> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:44 > >> + bool madePolicyDecision; > > > > isnt it more like it is accepted? "didAccept"? > > No, we want to know if "any" decision was made by the client (accept, reject or download). This is needed, to make a default policy decision ("accept" in this patch) in the case the client did not make an explicit decision. bool clientTookDecision; might be a bit more clear or actedUponByClient.. Comment on attachment 151691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151691&action=review >>>> Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp:44 >>>> + bool madePolicyDecision; >>> >>> isnt it more like it is accepted? "didAccept"? >> >> No, we want to know if "any" decision was made by the client (accept, reject or download). This is needed, to make a default policy decision ("accept" in this patch) in the case the client did not make an explicit decision. > > bool clientTookDecision; might be a bit more clear > > or actedUponByClient.. Ok, I'll clarify. Created attachment 151873 [details]
Patch
Take Kenneth's feedback into consideration.
Comment on attachment 151873 [details] Patch Clearing flags on attachment: 151873 Committed r122426: <http://trac.webkit.org/changeset/122426> All reviewed patches have been landed. Closing bug. |