Bug 90904

Summary: [Chromium-Android] Fix typos in chromium_android.py in r151492
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Layout and RenderingAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, james.wei, ojan, peter, tmpsantos, webkit.review.bot, zhenghao
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90894    
Attachments:
Description Flags
Patch ojan: review+, wangxianzhu: commit-queue-

Xianzhu Wang
Reported 2012-07-10 13:37:43 PDT
Sorry, I uploaded a wrong version of patch in bug 90894 which contains some typos. Will fix in this one.
Attachments
Patch (2.10 KB, patch)
2012-07-10 13:43 PDT, Xianzhu Wang 		ojan: review+
wangxianzhu: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-07-10 13:43:56 PDT
Created attachment 151511 [details] Patch
Xianzhu Wang
Comment 2 2012-07-10 14:10:28 PDT
Comment on attachment 151511 [details] Patch I'll submit it manually.
Xianzhu Wang
Comment 3 2012-07-10 14:13:55 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M Tools/ChangeLog M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py Committed r122261 M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py M Tools/ChangeLog r122261 = 213610f62c21101498758f42dcd5ab11851bf576 (refs/remotes/origin/master) No changes between current HEAD and refs/remotes/origin/master Resetting to the latest refs/remotes/origin/master
Thiago Marcos P. Santos
Comment 4 2012-07-10 15:04:18 PDT
It still doesn't solve all the problems: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2613/steps/webkitpy-test/logs/stdio ./Tools/Scripts/test-webkitpy is still failing.
Xianzhu Wang
Comment 5 2012-07-10 16:06:11 PDT
(In reply to comment #4) > It still doesn't solve all the problems: > > http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2613/steps/webkitpy-test/logs/stdio > > ./Tools/Scripts/test-webkitpy is still failing. Thanks for report. Fixed in r122273. Apology for making so many mistakes (and again the bad commit message).
Note You need to log in before you can comment on or make changes to this bug.