Summary: | [Chromium-Android] Use setup_test_runner() instead of start_helper() to setup test environment | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xianzhu Wang <wangxianzhu> | ||||
Component: | Tools / Tests | Assignee: | Xianzhu Wang <wangxianzhu> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, james.wei, mitz, ojan, peter, tmpsantos, webkit.review.bot, zhenghao | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Android | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 90904 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Xianzhu Wang
2012-07-10 10:33:43 PDT
Created attachment 151492 [details]
Patch
Comment on attachment 151492 [details] Patch Clearing flags on attachment: 151492 Committed r122251: <http://trac.webkit.org/changeset/122251> All reviewed patches have been landed. Closing bug. This patch broke EFL test runner: Traceback (most recent call last): File "./Tools/Scripts/test-webkitpy", line 64, in <module> sys.exit(not tester.run()) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/test/main.py", line 146, in run return self._run_tests(names) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/test/main.py", line 177, in _run_tests suites.append(loader.loadTestsFromName(name, None)) File "/usr/lib/python2.7/unittest/loader.py", line 103, in loadTestsFromName return self.loadTestsFromModule(obj) File "/usr/lib/python2.7/unittest/loader.py", line 65, in loadTestsFromModule tests.append(self.loadTestsFromTestCase(obj)) File "/usr/lib/python2.7/unittest/loader.py", line 56, in loadTestsFromTestCase loaded_suite = self.suiteClass(map(testCaseClass, testCaseNames)) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py", line 74, in __init__ self.test_port = host.port_factory.get('test-win-xp', None) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 110, in get module = __import__(module_name, globals(), locals(), [], -1) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py", line 62, in <module> DRT_APP_CACHE_DIR = DIR_APP_DIR + 'cache/' NameError: name 'DIR_APP_DIR' is not defined Sorry for the break. The patch (bug 90904) has been in CQ. (In reply to comment #5) > Sorry for the break. The patch (bug 90904) has been in CQ. No problem. Thanks for fixing. |