| Summary: | BitmapImage::frameIsCompleteAtIndex() must return false if ImageDecoder is not initialized. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dongseong Hwang <dongseong.hwang> | ||||
| Component: | Images | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gram, simon.fraser, skyul | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 90375, 90935 | ||||||
| Attachments: |
|
||||||
Created attachment 151205 [details]
Patch
Comment on attachment 151205 [details] Patch Clearing flags on attachment: 151205 Committed r122368: <http://trac.webkit.org/changeset/122368> All reviewed patches have been landed. Closing bug. |
The current code fortunately has worked so far because only BitmapImage::startAnimation calls frameIsCompleteAtIndex, and startAnimation cannot call frameIsCompleteAtIndex if ImageDecoder is not yet initialized. startAnimation returns at the first line becase shouldAnimate() always return false in this case. if (m_frameTimer || !shouldAnimate() || frameCount() <= 1) return; This change is needed because parallel image decoders call BitmapImage::frameIsCompleteAtIndex in other places too.