Summary: | [Qt] REGRESSION: 5 tests started to fail with newer Qt5 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | Marcelo Lira <marcelo.lira> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | allan.jensen, marcelo.lira, ossy, rafael.lobo, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 79666 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-07-06 07:09:48 PDT
Created attachment 164981 [details]
Patch
Comment on attachment 164981 [details] Patch Clearing flags on attachment: 164981 Committed r129234: <http://trac.webkit.org/changeset/129234> All reviewed patches have been landed. Closing bug. The new Qt5 specific results should have been put under platform/qt-5.0, not under platform/qt. We still support Qt-4.8 in test results. (In reply to comment #5) > The new Qt5 specific results should have been put under platform/qt-5.0, not under platform/qt. We still support Qt-4.8 in test results. Hmmm ... I thought we don't support Qt 4.8 on trunk anymore. Who knows if a test result is 4.8/5.0 specific or same on 4.8 and 5.0 ? (In reply to comment #6) > (In reply to comment #5) > > The new Qt5 specific results should have been put under platform/qt-5.0, not under platform/qt. We still support Qt-4.8 in test results. > > Hmmm ... I thought we don't support Qt 4.8 on trunk anymore. Who > knows if a test result is 4.8/5.0 specific or same on 4.8 and 5.0 ? In this case the commit message and bug specifically mentions it. (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > The new Qt5 specific results should have been put under platform/qt-5.0, not under platform/qt. We still support Qt-4.8 in test results. > > > > Hmmm ... I thought we don't support Qt 4.8 on trunk anymore. Who > > knows if a test result is 4.8/5.0 specific or same on 4.8 and 5.0 ? > > In this case the commit message and bug specifically mentions it. Sorry, my bad for mentioning Qt 4.8, since I had in mind that, as Ossy said, 4.8 was not supported anymore. (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > (In reply to comment #5) > > > > The new Qt5 specific results should have been put under platform/qt-5.0, not under platform/qt. We still support Qt-4.8 in test results. > > > > > > Hmmm ... I thought we don't support Qt 4.8 on trunk anymore. Who > > > knows if a test result is 4.8/5.0 specific or same on 4.8 and 5.0 ? > > > > In this case the commit message and bug specifically mentions it. > > Sorry, my bad for mentioning Qt 4.8, since I had in mind that, as Ossy said, 4.8 was not supported anymore. It isn't but we still share the same test-results (more or less). If we were to stop caring about the separation in trunk, we should rename the top Qt platform results from qt to qt-5.0, since the branching from qt to either qt-4.8 or qt-5.0 becomes meaningless. I agree, but when we have more qt versions in trunk, then we will have to bring qt folder back. |