Bug 90669

Summary: Fix loadRGBA8AsFloat to work with older GCC as well
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: dbates, yosin, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
patch2 zherczeg: review-

Gabor Rapcsanyi
Reported 2012-07-06 02:33:53 PDT
Fix loadRGBA8AsFloat to work with older GCC as well
Attachments
proposed patch (3.90 KB, patch)
2012-07-06 05:48 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
patch2 (2.98 KB, patch)
2012-07-06 06:32 PDT, Gabor Rapcsanyi 		zherczeg: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2012-07-06 05:48:22 PDT
Created attachment 151067 [details] proposed patch Fix loadRGBA8AsFloat and set FECompositeArithmeticNEON.h to use NEONHelpers as well.
Gabor Rapcsanyi
Comment 2 2012-07-06 06:32:08 PDT
Created attachment 151075 [details] patch2 The storeFloatAsRGBA8 in NEONHelpers.h different to what FEArithmeticNEON does so I leave that for now.
Zoltan Herczeg
Comment 3 2012-07-06 06:37:48 PDT
Comment on attachment 151075 [details] patch2 r=me
Zoltan Herczeg
Comment 4 2012-07-06 06:39:27 PDT
Comment on attachment 151075 [details] patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=151075&action=review > Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h:40 > - uint32x2_t temporary1 = vset_lane_u32(*source, temporary1, 0); > + uint32x2_t temporary1 = vld1_u32(source); I think vld1_u32 reads a whole register, which can lead to buffer overflow.
Gabor Rapcsanyi
Comment 5 2012-11-15 05:27:40 PST
Bug fixed with: https://bugs.webkit.org/show_bug.cgi?id=92797 *** This bug has been marked as a duplicate of bug 92797 ***
Daniel Bates
Comment 6 2014-02-13 14:44:31 PST
I extracted the change to use loadRGBA8AsFloat() into the patch for bug #128767.
Note You need to log in before you can comment on or make changes to this bug.