GCC 4.7 gives uninitialized value warning (treated as errors) against the following - (a) uint32x2_t temporary1 = vset_lane_u32(*source, temporary1, 0); This need to be fixed. The obvious way to do this is - (b) uint32x2_t temporary1 = {0, 0}; temporary1 = vset_lane_u32(*source, temporary1, 0); (a) and (b) generates exactly the same asm. A patch is attached.
Created attachment 155651 [details] proposed patch
Comment on attachment 155651 [details] proposed patch ChangeLog is needed for any minor change.
Created attachment 155683 [details] Proposed patch - 2
(In reply to comment #2) > (From update of attachment 155651 [details]) > ChangeLog is needed for any minor change. Hi kentaro, thanks! Uploaded a new patch with ChangeLog.
Comment on attachment 155683 [details] Proposed patch - 2 View in context: https://bugs.webkit.org/attachment.cgi?id=155683&action=review Please follow the normal ChangeLog format. You can refer to https://bugs.webkit.org/attachment.cgi?id=155661&action=review for example. > Source/WebCore/ChangeLog:4 > + - Bug URL. - Simple explanation of your change. - Tests. (You can just write "No tests. No change in behavior." in this case.)
Created attachment 155686 [details] proposed patch - 3
(In reply to comment #5) > (From update of attachment 155683 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155683&action=review > > Please follow the normal ChangeLog format. You can refer to https://bugs.webkit.org/attachment.cgi?id=155661&action=review for example. > > > Source/WebCore/ChangeLog:4 > > + > > - Bug URL. > - Simple explanation of your change. > - Tests. (You can just write "No tests. No change in behavior." in this case.) Hi Kentaro, done, thanks!
Comment on attachment 155686 [details] proposed patch - 3 Looks OK
(In reply to comment #8) > (From update of attachment 155686 [details]) > Looks OK Does that mean I could proceed landing it? Or I need approval? Thanks!
Comment on attachment 155686 [details] proposed patch - 3 Please change "cq " to "cq?" (at the right bottom of https://bugs.webkit.org/attachment.cgi?id=155686&action=review). Then I can change it to "cq+", by which the patch will be committed. (Already done for this patch.)
(In reply to comment #10) > (From update of attachment 155686 [details]) > Please change "cq " to "cq?" (at the right bottom of https://bugs.webkit.org/attachment.cgi?id=155686&action=review). Then I can change it to "cq+", by which the patch will be committed. (Already done for this patch.) Thanks!
Comment on attachment 155686 [details] proposed patch - 3 Rejecting attachment 155686 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13400672
Created attachment 155712 [details] Patch ready for landing ("Reviewer added to ChangeLog")
Created attachment 155713 [details] Patch ready for landing
Comment on attachment 155713 [details] Patch ready for landing Rejecting attachment 155713 [details] from review queue. shenhan@google.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Comment on attachment 155713 [details] Patch ready for landing Rejecting attachment 155713 [details] from commit-queue. shenhan@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 155686 [details] proposed patch - 3 Cleared Kentaro Hara's review+ from obsolete attachment 155686 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment on attachment 155712 [details] Patch ready for landing ("Reviewer added to ChangeLog") Cleared review+ from obsolete attachment 155712 [details] so that this bug does not appear in http://webkit.org/pending-commit.
(In reply to comment #10) > (From update of attachment 155686 [details]) > Please change "cq " to "cq?" (at the right bottom of https://bugs.webkit.org/attachment.cgi?id=155686&action=review). Then I can change it to "cq+", by which the patch will be committed. (Already done for this patch.) Hi Kentaro, sorry, I had to add "Reviewed by - " to the ChangeLog, could you do that "cq+" again? Thanks, -Han
Done.
(In reply to comment #22) > Done. That's super fast, thanks!
Comment on attachment 155713 [details] Patch ready for landing Clearing flags on attachment: 155713 Committed r124341: <http://trac.webkit.org/changeset/124341>
All reviewed patches have been landed. Closing bug.
*** Bug 90669 has been marked as a duplicate of this bug. ***