Bug 128767 - Write FEComposite::computeArithmeticPixelsNeon() in terms of loadRGBA8AsFloat()
Summary: Write FEComposite::computeArithmeticPixelsNeon() in terms of loadRGBA8AsFloat()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-13 14:29 PST by Daniel Bates
Modified: 2014-02-13 15:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2014-02-13 14:30 PST, Daniel Bates 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-02-13 14:29:36 PST 
We should use loadRGBA8AsFloat() instead of duplicating similar code in FEComposite::computeArithmeticPixelsNeon(). Also, this will resolve the following uninitialized variable compiler warning:

Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:52:61: error: variable 'temporary1' is uninitialized when used within its own initialization [-Werror,-Wuninitialized]
        uint32x2_t temporary1 = vset_lane_u32(*sourcePixel, temporary1, 0);
Comment 1 Daniel Bates 2014-02-13 14:30:19 PST 
Created attachment 224111 [details]
Patch
Comment 2 Daniel Bates 2014-02-13 14:40:40 PST 
Committed r164058: <http://trac.webkit.org/changeset/164058>
Comment 3 Daniel Bates 2014-02-13 15:30:44 PST 
Included header NEONHelpers.h and committed build fix in <http://trac.webkit.org/changeset/164060>.