Bug 90615 – Web Inspector: Add native memory used by GlyphCache to the snapshot

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Alexei Filippov]

EOM

[Alexei Filippov]

Created attachment 150949 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 150949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150949&action=review

> Source/WebCore/platform/MemoryUsageSupport.cpp:66
> +bool MemoryUsageSupport::componentMemoryUsageInBytes(const char* name, size_t* size)

Please remove parameter names to avoid warnings.

> Source/WebCore/platform/MemoryUsageSupport.h:63
> +    static bool componentMemoryUsageInBytes(const char*, size_t*);

This way we need to store all component names in the memory agent that calls this method. It might be better to have MemoryUsageSupport report us {component name -> size} map containing information about all components. WDYT?

[Build Bot]

Comment on attachment 150949 [details]
Patch

Attachment 150949 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13154058

[Alexei Filippov]

Created attachment 150955 [details]
Patch

[Alexei Filippov]

Comment on attachment 150949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150949&action=review

>> Source/WebCore/platform/MemoryUsageSupport.cpp:66
>> +bool MemoryUsageSupport::componentMemoryUsageInBytes(const char* name, size_t* size)
> 
> Please remove parameter names to avoid warnings.

done

>> Source/WebCore/platform/MemoryUsageSupport.h:63
>> +    static bool componentMemoryUsageInBytes(const char*, size_t*);
> 
> This way we need to store all component names in the memory agent that calls this method. It might be better to have MemoryUsageSupport report us {component name -> size} map containing information about all components. WDYT?

done

[Yury Semikhatsky]

Comment on attachment 150955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150955&action=review

> Source/WebCore/platform/MemoryUsageSupport.h:67
> +        const char* m_name;

Why not const String? It would be more convenient should we have dynamically generated names.

> Source/WebCore/platform/MemoryUsageSupport.h:68
> +        size_t m_size;

m_sizeInBytes ?

[Alexei Filippov]

Created attachment 151071 [details]
Patch

[Alexei Filippov]

Comment on attachment 150955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150955&action=review

>> Source/WebCore/platform/MemoryUsageSupport.h:67
>> +        const char* m_name;
> 
> Why not const String? It would be more convenient should we have dynamically generated names.

done

>> Source/WebCore/platform/MemoryUsageSupport.h:68
>> +        size_t m_size;
> 
> m_sizeInBytes ?

done

[WebKit Review Bot]

Comment on attachment 151071 [details]
Patch

Clearing flags on attachment: 151071

Committed r121968: <http://trac.webkit.org/changeset/121968>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 90745

[Alexei Filippov]

Created attachment 155525 [details]
Patch

[WebKit Review Bot]

Comment on attachment 155525 [details]
Patch

Attachment 155525 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13400444

[Early Warning System Bot]

Comment on attachment 155525 [details]
Patch

Attachment 155525 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13387781

[Early Warning System Bot]

Comment on attachment 155525 [details]
Patch

Attachment 155525 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13403197

[Alexei Filippov]

Created attachment 155551 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 155551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155551&action=review

> Source/WebCore/platform/MemoryUsageSupport.h:34
> +#include <wtf/Vector.h>

wtf/Forward.h should be enough

[Early Warning System Bot]

Comment on attachment 155551 [details]
Patch

Attachment 155551 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13392770

[Early Warning System Bot]

Comment on attachment 155551 [details]
Patch

Attachment 155551 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13393693

[Alexei Filippov]

Created attachment 155582 [details]
Patch

[WebKit Review Bot]

Comment on attachment 155582 [details]
Patch

Rejecting attachment 155582 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Source/WebCore/platform/MemoryUsageSupport.h
patching file Source/WebCore/platform/chromium/MemoryUsageSupportChromium.cpp
patching file Source/WebCore/platform/qt/MemoryUsageSupportQt.cpp
patching file Source/WebKit/chromium/DEPS
Hunk #1 FAILED at 32.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/DEPS.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Yury Semik..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13411302

[Alexei Filippov]

Created attachment 155748 [details]
Patch

[WebKit Review Bot]

Comment on attachment 155748 [details]
Patch

Clearing flags on attachment: 155748

Committed r124315: <http://trac.webkit.org/changeset/124315>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.