Summary: | [WK2][EFL] Ewk_View should report the load progress | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, lucas.de.marchi, ryuan.choi, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 61838 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2012-07-03 06:33:27 PDT
Created attachment 150598 [details]
Patch
Created attachment 150648 [details]
Patch
Rebase on master
Comment on attachment 150648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150648&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:575 > + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, -1); > + EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, -1); Wouldnt 0 be a better value? It is not loaded? instead of invalid... seems like more code to handle for users of this api > Tools/MiniBrowser/efl/main.c:95 > + char label[4096]; Wouldnt it be better to use a string builder or so instead? then get the string from that. Created attachment 150715 [details]
Patch
Take Kenneth feedback into consideration.
Comment on attachment 150715 [details] Patch Clearing flags on attachment: 150715 Committed r121830: <http://trac.webkit.org/changeset/121830> All reviewed patches have been landed. Closing bug. |