Bug 90439

Summary: Web Inspector: Add text file support for FileSystemAgent::requestFileContent
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: Web Inspector (Deprecated)Assignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 68203, 90529, 90592    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Taiju Tsuiki
Reported 2012-07-03 02:20:28 PDT
For FileSystem support of Inspector, text file support is needed. That is, I'd like to add: - Charset detection - Text decoding on load - Charset override to backend InspectorFileSystemAgent.
Attachments
Patch (20.92 KB, patch)
2012-07-03 02:22 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (21.26 KB, patch)
2012-07-04 01:06 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (24.28 KB, patch)
2012-07-09 00:29 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (24.71 KB, patch)
2012-07-09 00:49 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (24.71 KB, patch)
2012-07-09 01:10 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (24.42 KB, patch)
2012-07-09 01:22 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Taiju Tsuiki
Comment 1 2012-07-03 02:22:52 PDT
Created attachment 150563 [details] Patch
Taiju Tsuiki
Comment 2 2012-07-04 01:06:35 PDT
Created attachment 150735 [details] Patch
Vsevolod Vlasov
Comment 3 2012-07-05 14:06:47 PDT
Comment on attachment 150735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150735&action=review > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:111 > + return mimeType.startsWith("text/") || mimeType.endsWith("+xml") || mimeType.endsWith("/javascript"); See NetworkResourcesData (http://code.google.com/p/chromium/source/search?q=file%3Ainspector+%22.mimetype+%3D+%22&origq=file%3Ainspector+%22.mimetype+%3D+%22&btnG=Search+Trunk) for a more precise text and charset detection (at least for xml mime-types). Can we reuse it?
Taiju Tsuiki
Comment 4 2012-07-09 00:29:10 PDT
Created attachment 151197 [details] Patch
Taiju Tsuiki
Comment 5 2012-07-09 00:49:31 PDT
Created attachment 151203 [details] Patch
Taiju Tsuiki
Comment 6 2012-07-09 01:10:33 PDT
Created attachment 151207 [details] Patch
Taiju Tsuiki
Comment 7 2012-07-09 01:22:12 PDT
Created attachment 151209 [details] Patch
WebKit Review Bot
Comment 8 2012-07-09 03:52:28 PDT
Comment on attachment 151209 [details] Patch Clearing flags on attachment: 151209 Committed r122101: <http://trac.webkit.org/changeset/122101>
WebKit Review Bot
Comment 9 2012-07-09 03:52:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.