Summary: | Web Inspector: Add text file support for FileSystemAgent::requestFileContent | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Taiju Tsuiki <tzik> | ||||||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Taiju Tsuiki <tzik> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 68203, 90529, 90592 | ||||||||||||||||
Attachments: |
|
Description
Taiju Tsuiki
2012-07-03 02:20:28 PDT
Created attachment 150563 [details]
Patch
Created attachment 150735 [details]
Patch
Comment on attachment 150735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150735&action=review > Source/WebCore/inspector/InspectorFileSystemAgent.cpp:111 > + return mimeType.startsWith("text/") || mimeType.endsWith("+xml") || mimeType.endsWith("/javascript"); See NetworkResourcesData (http://code.google.com/p/chromium/source/search?q=file%3Ainspector+%22.mimetype+%3D+%22&origq=file%3Ainspector+%22.mimetype+%3D+%22&btnG=Search+Trunk) for a more precise text and charset detection (at least for xml mime-types). Can we reuse it? Created attachment 151197 [details]
Patch
Created attachment 151203 [details]
Patch
Created attachment 151207 [details]
Patch
Created attachment 151209 [details]
Patch
Comment on attachment 151209 [details] Patch Clearing flags on attachment: 151209 Committed r122101: <http://trac.webkit.org/changeset/122101> All reviewed patches have been landed. Closing bug. |