Summary: | Remove more BUILDING_ON_LEOPARD branches now that no port builds on Leopard | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | abarth, jberlin, keishi, laszlo.gombos, mark, rniwa, thakis, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 90250, 90260 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Eric Seidel (no email)
2012-06-29 00:16:37 PDT
Created attachment 150097 [details]
Patch
Comment on attachment 150097 [details] Patch Clearing flags on attachment: 150097 Committed r121529: <http://trac.webkit.org/changeset/121529> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by 90260 Sorry I had to revert. Here is the compile log. (view as text) python ../../../scripts/slave/compile.py --target Release --build-dir src/build --build-tool=ninja --compiler=goma-clang -- test_shell test_shell_tests webkit_unit_tests DumpRenderTree in dir /Volumes/data/b/build/slave/webkit-mac-latest-rel/build (timeout 1200 secs) watching logfiles {} argv: ['python', '../../../scripts/slave/compile.py', '--target', 'Release', '--build-dir', 'src/build', '--build-tool=ninja', '--compiler=goma-clang', '--', 'test_shell', 'test_shell_tests', 'webkit_unit_tests', 'DumpRenderTree'] environment: CHROME_HEADLESS=1 DISPLAY=/tmp/launch-Gle923/org.x:0 HOME=/Users/chrome-bot LOGNAME=chrome-bot PAGER=cat PATH=/Volumes/data/b/depot_tools:/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin PWD=/Volumes/data/b/build/slave/webkit-mac-latest-rel/build PYTHONPATH=/Volumes/data/b/build/site_config:/Volumes/data/b/build/scripts:/Volumes/data/b/build/scripts/release:/Volumes/data/b/build/third_party:/Volumes/data/b/build_internal/site_config:/Volumes/data/b/build_internal/symsrc:/Volumes/data/b/build/slave:/Volumes/data/b/build/third_party/buildbot_7_12:/Volumes/data/b/build/third_party/twisted_8_1:/Volumes/data/b/build/third_party/buildbot_7_12:/Volumes/data/b/build/third_party/twisted_8_1: SHELL=/bin/bash SSH_AUTH_SOCK=/tmp/launch-DWjWvv/Listeners USER=chrome-bot closing stdin using PTY: True /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /Volumes/data/b/build/third_party/twisted_8_1/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /Volumes/data/b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path import pkg_resources chdir to /Volumes/data/b/build/slave/webkit-mac-latest-rel/build/src /Volumes/data/b/build/goma/goma_ctl.sh ensure_start Using goma VERSION=23 (no_auto_update)... GOMA: compiler_proxy: there is already someone else with lock Failed to start compiler_proxy. compiler proxy status: http://127.0.0.1:8094/ alive Now goma is ready! using goma-clang Environment variables set in compile.py: GOMA_API_KEY_FILE=/Volumes/data/b/build/goma/goma.key GOMA_COMPILER_PROXY_DAEMON_MODE=true PATH=/Volumes/data/b/build/goma:/Volumes/data/b/build/slave/webkit-mac-latest-rel/build/src/third_party/llvm-build/Release+Asserts/bin:/Volumes/data/b/depot_tools:/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin ninja -C out/Release test_shell test_shell_tests webkit_unit_tests DumpRenderTree -j50 ninja: Entering directory `out/Release' [1/1465] ACTION Validate inspector protocol for backwards compatibility and generate version file [2/1465] ACTION concatenated_devtools_css: concatenate_devtools_css_102fd71d961b87ddc04a7b56913d1411 [3/1465] CXX obj/third_party/WebKit/Source/WTF/wtf/unicode/icu/wtf.CollatorICU.o [4/1465] STAMP obj/third_party/WebKit/Source/WebKit/chromium/concatenated_devtools_css.actions_rules_copies.stamp [5/1465] ACTION Generating Inspector protocol sources from Inspector.json [6/1465] STAMP obj/third_party/WebKit/Source/WebCore/WebCore.gyp/inspector_protocol_sources.actions_rules_copies.stamp [7/1465] STAMP obj/third_party/WebKit/Source/WebKit/chromium/concatenated_devtools_js.actions_depends.stamp [8/1465] STAMP obj/third_party/WebKit/Source/WebCore/WebCore.gyp/webcore_bindings.actions_depends.stamp [9/1465] STAMP obj/third_party/WebKit/Source/WebCore/WebCore.gyp/webcore_bindings.compile_depends.stamp [10/1465] STAMP obj/third_party/WebKit/Source/WebCore/WebCore.gyp/webcore_prerequisites.compile_depends.stamp [11/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources03.o [12/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources06.o [13/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources01.o [14/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources02.o [15/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources04.o [16/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources05.o [17/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources11.o [18/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources07.o [19/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources08.o [20/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources09.o [21/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources10.o [22/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources13.o [23/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources12.o [24/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources14.o [25/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources15.o [26/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources16.o [27/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources17.o [28/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources18.o [29/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/bindings/webcore_bindings.V8DerivedSources19.o [30/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webcore/webcore_bindings.InspectorBackendDispatcher.o [31/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/webcore_bindings.HTMLElementFactory.o [32/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/webcore_bindings.EventFactory.o [33/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/webcore_bindings.V8HTMLElementWrapperFactory.o [34/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/webcore_bindings.CSSGrammar.o [35/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webcore/webcore_bindings.InspectorFrontend.o [36/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webcore/webcore_bindings.InspectorTypeBuilder.o [37/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/webcore_bindings.SVGElementFactory.o [38/1465] CXX obj/third_party/WebKit/Source/WebCore/WebCore.gyp/gen/webkit/webcore_bindings.V8SVGElementWrapperFactory.o [39/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.FixedTableLayout.o [40/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.AutoTableLayout.o [41/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.BidiRun.o [42/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.CounterNode.o [43/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.EllipsisBox.o [44/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.FilterEffectRenderer.o [45/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.FlowThreadController.o [46/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.HitTestResult.o [47/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.RenderBR.o [48/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.InlineBox.o [49/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.InlineFlowBox.o [50/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.InlineTextBox.o [51/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.LayoutState.o [52/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.LayoutRepainter.o [53/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.RenderBlockLineLayout.o [54/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.RenderApplet.o [55/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.RenderFrameBase.o [56/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.RenderBlock.o [57/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.RenderBox.o [58/1465] CXX obj/third_party/WebKit/Source/WebCore/rendering/webcore_rendering.RenderDeprecatedFlexibleBox.o [59/1465] ACTION concatenated_devtools_js: concatenate_devtools_js_510d6e299d3755d417bec17c50397412 FAILED: clang++ -MMD -MF obj/third_party/WebKit/Source/WTF/wtf/unicode/icu/wtf.CollatorICU.o.d -DCHROMIUM_BUILD -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_PROMO_RESOURCE_SERVICE=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_3D_PLUGIN=1 -DENABLE_BATTERY_STATUS=0 -DENABLE_BLOB=1 -DENABLE_BLOB_SLICE=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_CSP_NEXT=1 -DENABLE_CSS3_FLEXBOX=1 -DENABLE_CSS_BOX_DECORATION_BREAK=1 -DENABLE_CSS_EXCLUSIONS=1 -DENABLE_CSS_FILTERS=1 -DENABLE_CSS_IMAGE_SET=1 -DENABLE_CSS_IMAGE_RESOLUTION=0 -DENABLE_CSS_REGIONS=1 -DENABLE_CSS_SHADERS=1 -DENABLE_CSS_VARIABLES=0 -DENABLE_CUSTOM_SCHEME_HANDLER=0 -DENABLE_DATALIST=1 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_DATA_TRANSFER_ITEMS=1 -DENABLE_DETAILS=1 -DENABLE_DEVICE_ORIENTATION=1 -DENABLE_DIRECTORY_UPLOAD=1 -DENABLE_DOWNLOAD_ATTRIBUTE=1 -DENABLE_ENCRYPTED_MEDIA=1 -DENABLE_FILE_SYSTEM=1 -DENABLE_FILTERS=1 -DENABLE_FULLSCREEN_API=1 -DENABLE_GAMEPAD=1 -DENABLE_GEOLOCATION=1 -DENABLE_GESTURE_EVENTS=1 -DENABLE_ICONDATABASE=0 -DENABLE_IFRAME_SEAMLESS=1 -DENABLE_INDEXED_DATABASE=1 -DENABLE_INPUT_TYPE_DATE=1 -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_LEGACY_CSS_VENDOR_PREFIXES=0 -DENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1 -DENABLE_LINK_PREFETCH=1 -DENABLE_LINK_PRERENDER=1 -DENABLE_MEDIA_SOURCE=1 -DENABLE_MEDIA_STATISTICS=1 -DENABLE_METER_TAG=1 -DENABLE_MHTML=1 -DENABLE_MICRODATA=0 -DENABLE_MUTATION_OBSERVERS=1 -DENABLE_PAGE_VISIBILITY_API=1 -DENABLE_POINTER_LOCK=1 -DENABLE_PROGRESS_TAG=1 -DENABLE_QUOTA=1 -DENABLE_REGISTER_PROTOCOL_HANDLER=1 -DENABLE_REQUEST_ANIMATION_FRAME=1 -DENABLE_RUBY=1 -DENABLE_SANDBOX=1 -DENABLE_SCRIPTED_SPEECH=1 -DENABLE_SHADOW_DOM=1 -DENABLE_SMOOTH_SCROLLING=1 -DENABLE_SQL_DATABASE=1 -DENABLE_STYLE_SCOPED=1 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_TOUCH_ADJUSTMENT=1 -DENABLE_TOUCH_EVENTS=1 -DENABLE_TOUCH_ICON_LOADING=0 -DENABLE_V8_SCRIPT_DEBUG_SERVER=1 -DENABLE_VIDEO=1 -DENABLE_VIDEO_TRACK=1 -DENABLE_VIEWPORT=1 -DENABLE_WEBGL=1 -DENABLE_WEB_SOCKETS=1 -DENABLE_WEB_TIMING=1 -DENABLE_WORKERS=1 -DENABLE_XHR_RESPONSE_BLOB=1 -DENABLE_XSLT=1 -DWTF_USE_LEVELDB=1 -DWTF_USE_BUILTIN_UTF8_CODEC=1 -DWTF_USE_OPENTYPE_SANITIZER=1 -DWTF_USE_RTL_SCROLLBAR=1 -DWTF_USE_SKIA_TEXT=1 -DWTF_USE_WEBP=1 -DWTF_USE_WEBKIT_IMAGE_DECODERS=1 -DENABLE_CALENDAR_PICKER=1 -DENABLE_FONT_BOOSTING=0 -DENABLE_INPUT_SPEECH=1 -DENABLE_INPUT_TYPE_COLOR=1 -DENABLE_JAVASCRIPT_I18N_API=1 -DENABLE_LEGACY_NOTIFICATIONS=1 -DENABLE_MEDIA_CAPTURE=0 -DENABLE_MEDIA_STREAM=1 -DENABLE_NOTIFICATIONS=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_OVERFLOW_SCROLLING=0 -DENABLE_PAGE_POPUP=1 -DENABLE_SHARED_WORKERS=1 -DENABLE_WEB_AUDIO=1 -DENABLE_3D_RENDERING=1 -DENABLE_ACCELERATED_2D_CANVAS=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DENABLE_RUBBER_BANDING=1 -DWTF_USE_SKIA_ON_MAC_CHROMIUM=1 -DBUILDING_CHROMIUM__=1 -DUSE_SYSTEM_MALLOC=1 -DWTF_USE_NEW_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/icu/public/common -I../../third_party/icu/public/i18n -I../../third_party/WebKit/Source/WTF -I../../third_party/WebKit/Source/WTF/wtf -I../../third_party/WebKit/Source/WTF/wtf/unicode -isysroot /Developer/SDKs/MacOSX10.5.sdk -O3 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.5 -arch i386 -Wendif-labels -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-char-subscripts -Wno-unused-function -Wno-unnamed-type-template-args -Wno-c++11-extensions -Wno-covered-switch-default -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -fno-strict-aliasing -Xclang -load -Xclang /Volumes/data/b/build/slave/webkit-mac-latest-rel/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations -fcolor-diagnostics -c ../../third_party/WebKit/Source/WTF/wtf/unicode/icu/CollatorICU.cpp -o obj/third_party/WebKit/Source/WTF/wtf/unicode/icu/wtf.CollatorICU.o ../../third_party/WebKit/Source/WTF/wtf/unicode/icu/CollatorICU.cpp:66:85: error: use of undeclared identifier 'kCFLocaleCollatorIdentifier'; did you mean 'kCFLocaleCollationIdentifier'? CFStringRef collationOrder = (CFStringRef)CFLocaleGetValue(currentLocale.get(), kCFLocaleCollatorIdentifier); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ kCFLocaleCollationIdentifier /Developer/SDKs/MacOSX10.5.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFLocale.h:140:29: note: 'kCFLocaleCollationIdentifier' declared here CF_EXPORT const CFStringRef kCFLocaleCollationIdentifier AVAILABLE_MAC_OS_X_VERSION_10_4_AND_LATER; ^ 1 error generated. ninja: build stopped: subcommand failed. program finished with exit code 1 elapsedTime=36.894931 The change looks OK to me... Are we sure this bot isn't using leopard? Leopard is no longer supported by Chromium is my understanding. Ah, I see. That command line is using /Developer/SDKs/MacOSX10.5.sdk. That seems wrong. Presumably we need to fix the gyp file too. fwiw, the upstream chromium bots still build with the 10.5 sdk. That's supposed to change in the next two weeks. I'm not sure if you're blocked on that. I believe we don't use the BUILDING_ON_ macros for chromium/mac, so this could've been done long ago probably (?). Well, until we change base.gypi's: 'mac_sdk%': '10.5', 'mac_deployment_target%': '10.5', to be 10.6, this patch can't work. :) If it's OK to do that, I can post a patch. But I'm also happy to wait. This work is in no hurry. I just heard from Adam last night that Leopard was officially dead and decided to finally go back and look at removing more leopard code again (we have a shocking amount of leopard-specific code). Leopard is dead for Chrome on the trunk, but we’re not quite ready to switch the SDK or deployment target yet. it should happen in the next couple of weeks. (In reply to comment #10) > Leopard is dead for Chrome on the trunk, but we’re not quite ready to switch the SDK or deployment target yet. it should happen in the next couple of weeks. Do we have a bug tracking that? (So I can know when I can land these?) I assume we're just waiting for QA to OK the binary? or are there technical challenges associated with changing the SDK? (I should note, I'm not in any hurry, just like to be kept in the loop.) It appears that Chromium no longer use the 10.5 SDK, but now uses the 10.6 SDK, targeting 10.5 still. So I'll wait a bit more. http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?view=markup is where you find this stuff these days. We’re trying to switch the deployment target to 10.6 too, but we’ve got to make a few more source-level changes first including, likely, some changes in WebKit. Watch http://crbug.com/137676 to follow our progress. Thanks Mark. I'm in no hurry at all. Just looking back through some old bugmail. It seems like the chromium issue has been resolved. I think we're ready to come back to this bug. This is a bit tricker to search/replace for now that the BUILDING_ON_* macros were replaced with version comparisons. *** This bug has been marked as a duplicate of bug 107964 *** |