Bug 90250 - Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard)
Summary: Remove Leopard Accessibility support from WebCore (now that no port builds on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 90249
Blocks: 90252
  Show dependency treegraph
 
Reported: 2012-06-29 00:06 PDT by Eric Seidel (no email)
Modified: 2013-02-14 11:24 PST (History)
10 users (show)

See Also:


Attachments
Patch (6.09 KB, patch)
2012-06-29 00:07 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cq-03 (572.13 KB, application/zip)
2012-06-29 04:59 PDT, WebKit Review Bot
no flags Details
Archive of layout-test-results from ec2-cr-linux-01 (649.90 KB, application/zip)
2012-06-29 06:07 PDT, WebKit Review Bot
no flags Details
patch (7.34 KB, patch)
2013-02-13 15:02 PST, chris fleizach
eric: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (8.04 KB, patch)
2013-02-14 10:49 PST, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-06-29 00:06:43 PDT
Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard)
Comment 1 Eric Seidel (no email) 2012-06-29 00:07:22 PDT
Created attachment 150094 [details]
Patch
Comment 2 Ryosuke Niwa 2012-06-29 00:28:53 PDT
Comment on attachment 150094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150094&action=review

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:46
>      m_isAccessibilityTable = true;

Should we initialize this on the initialization list now that if-def is gone?

> Source/WebCore/accessibility/AccessibilityTable.cpp:54
>      m_isAccessibilityTable = isTableExposableThroughAccessibility();

Ditto.
Comment 3 Eric Seidel (no email) 2012-06-29 00:40:25 PDT
Comment on attachment 150094 [details]
Patch

A task for another day. :)
Comment 4 WebKit Review Bot 2012-06-29 04:59:09 PDT
Comment on attachment 150094 [details]
Patch

Rejecting attachment 150094 [details] from commit-queue.

New failing tests:
accessibility/aria-roles.html
Full output: http://queues.webkit.org/results/13109339
Comment 5 WebKit Review Bot 2012-06-29 04:59:12 PDT
Created attachment 150142 [details]
Archive of layout-test-results from ec2-cq-03

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: ec2-cq-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 WebKit Review Bot 2012-06-29 06:07:28 PDT
Comment on attachment 150094 [details]
Patch

Attachment 150094 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13106390

New failing tests:
accessibility/aria-roles.html
Comment 7 WebKit Review Bot 2012-06-29 06:07:32 PDT
Created attachment 150162 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 Eric Seidel (no email) 2013-01-04 23:15:34 PST
These comparisons are all now with MAC_OS_X_VERSION_MIN_REQUIRED, which makes them slightly harder to grep for/remove unfortunately.
Comment 9 Eric Seidel (no email) 2013-02-13 12:02:27 PST
Comment on attachment 150094 [details]
Patch

I don't plan to take this on again anytime soon.
Comment 10 chris fleizach 2013-02-13 12:04:52 PST
(In reply to comment #9)
> (From update of attachment 150094 [details])
> I don't plan to take this on again anytime soon.

Are you saying you want someone else to finish this up?
Comment 11 Eric Seidel (no email) 2013-02-13 12:06:21 PST
That would be fine. I'm also happy to close this.  I'm not actively working on removing LEOPARD code right now.
Comment 12 chris fleizach 2013-02-13 12:21:01 PST
Comment on attachment 150094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150094&action=review

>> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:46
>>      m_isAccessibilityTable = true;
> 
> Should we initialize this on the initialization list now that if-def is gone?

yes we can do this one

>> Source/WebCore/accessibility/AccessibilityTable.cpp:54
>>      m_isAccessibilityTable = isTableExposableThroughAccessibility();
> 
> Ditto.

i believe there were some issues in calling this method from the constructor. Right now it lives in the init() method
Comment 13 chris fleizach 2013-02-13 15:02:25 PST
Created attachment 188191 [details]
patch
Comment 14 Eric Seidel (no email) 2013-02-13 15:35:44 PST
Comment on attachment 188191 [details]
patch

Looks reasonable to me.
Comment 15 Build Bot 2013-02-13 16:43:12 PST
Comment on attachment 188191 [details]
patch

Attachment 188191 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16580061

New failing tests:
platform/mac/accessibility/aria-treegrid.html
Comment 16 chris fleizach 2013-02-14 10:49:34 PST
Created attachment 188384 [details]
patch for landing
Comment 17 chris fleizach 2013-02-14 10:50:49 PST
(In reply to comment #16)
> Created an attachment (id=188384) [details]
> patch for landing

Previous patch caused that test to fail because AccessibilityARIAGrid wasn't calling AXRenderObject::init

The easy fix is for AXARIAGrid to override isTableExposableThroughAccessibility() and return true instead of trying to have AXTable return a value for AXARIAGrid
Comment 18 chris fleizach 2013-02-14 11:24:21 PST
http://trac.webkit.org/changeset/142895