http://trac.webkit.org/changeset/121529 broke the build: Failed to compile on Chromium WebKitMacBuilder (Requested by keishi on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Created attachment 150118 [details] ROLLOUT of r121529 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Comment on attachment 150118 [details] ROLLOUT of r121529 Clearing flags on attachment: 150118 Committed r121536: <http://trac.webkit.org/changeset/121536>
All reviewed patches have been landed. Closing bug.
Are we sure this bot isn't using Leopard? That constant is available in 10.6: CF_EXPORT const CFStringRef kCFLocaleCollatorIdentifier AVAILABLE_MAC_OS_X_VERSION_10_6_AND_LATER; It's also possible that I typo'd something in my change.
http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/39055/steps/compile-webkit/logs/stdio Here are some errors: In file included from /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../platform/chromium/ThemeChromiumMac.mm:34: ../platform/mac/WebCoreSystemInterface.h:300:9: fatal error: 'dispatch/dispatch.h' file not found #import <dispatch/dispatch.h> ^ 1 error generated. /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../platform/text/cf/HyphenationCF.cpp:43:12: error: use of undeclared identifier 'CFStringIsHyphenationAvailableForLocale' return CFStringIsHyphenationAvailableForLocale(locale.get()) ? locale : 0; ^ /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../platform/text/cf/HyphenationCF.cpp:52:12: error: use of undeclared identifier 'CFStringIsHyphenationAvailableForLocale' return CFStringIsHyphenationAvailableForLocale(locale.get()) ? locale : 0; ^ /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../platform/text/cf/HyphenationCF.cpp:73:22: error: use of undeclared identifier 'CFStringGetHyphenationLocationBeforeIndex' CFIndex result = CFStringGetHyphenationLocationBeforeIndex(string.get(), beforeIndex, CFRangeMake(0, length), 0, locale.get(), 0); ^ 3 errors generated.
These are caused by Chromium using the 10.5sdk.... which is wrong now that it doesn't support Leopard, but will be a bit until its fixed I'm told: https://bugs.webkit.org/show_bug.cgi?id=90252#c10