Summary: | [chromium] Reset the device scale factor to 1 before each test is run | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Terry Anderson <tdanderson> | ||||||
Component: | Tools / Tests | Assignee: | Terry Anderson <tdanderson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, senorblanco, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 88121 | ||||||||
Attachments: |
|
Description
Terry Anderson
2012-06-28 14:56:59 PDT
Created attachment 150024 [details]
Patch
Comment on attachment 150024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150024&action=review > Tools/ChangeLog:6 > + Reviewed by Adam Barth. You should leave this line with the NOBODY (OOPS)! string. The tools will fill it in based on who actually reviews the patch. Comment on attachment 150024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150024&action=review > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:653 > + m_shell->webView()->setDeviceScaleFactor(1.0); Nit: "Unless required in order to force floating point math, do not append .0, .f and .0f to floating point literals." Comment on attachment 150024 [details]
Patch
Thanks.
Created attachment 150031 [details]
Patch
Comment on attachment 150031 [details] Patch Clearing flags on attachment: 150031 Committed r121489: <http://trac.webkit.org/changeset/121489> All reviewed patches have been landed. Closing bug. |