Bug 90212

Summary: [chromium] Reset the device scale factor to 1 before each test is run
Product: WebKit Reporter: Terry Anderson <tdanderson>
Component: Tools / TestsAssignee: Terry Anderson <tdanderson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, senorblanco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88121    
Attachments:
Description Flags
Patch
none
Patch none

Terry Anderson
Reported 2012-06-28 14:56:59 PDT
Tests using testRunner.setBackingScaleFactor change the device scale factor but do not reset this back to 1 at the end of the test. This leads to a large number of flaky tests as noted in https://bugs.webkit.org/show_bug.cgi?id=83635
Attachments
Patch (1.44 KB, patch)
2012-06-28 15:12 PDT, Terry Anderson 		no flags
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2012-06-28 15:48 PDT, Terry Anderson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Terry Anderson
Comment 1 2012-06-28 15:12:07 PDT
Created attachment 150024 [details] Patch
Adam Barth
Comment 2 2012-06-28 15:15:20 PDT
Comment on attachment 150024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150024&action=review > Tools/ChangeLog:6 > + Reviewed by Adam Barth. You should leave this line with the NOBODY (OOPS)! string. The tools will fill it in based on who actually reviews the patch.
Stephen White
Comment 3 2012-06-28 15:20:11 PDT
Comment on attachment 150024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150024&action=review > Tools/DumpRenderTree/chromium/LayoutTestController.cpp:653 > + m_shell->webView()->setDeviceScaleFactor(1.0); Nit: "Unless required in order to force floating point math, do not append .0, .f and .0f to floating point literals."
Adam Barth
Comment 4 2012-06-28 15:36:38 PDT
Comment on attachment 150024 [details] Patch Thanks.
Terry Anderson
Comment 5 2012-06-28 15:48:24 PDT
Created attachment 150031 [details] Patch
Adam Barth
Comment 6 2012-06-28 17:01:48 PDT
Comment on attachment 150031 [details] Patch Clearing flags on attachment: 150031 Committed r121489: <http://trac.webkit.org/changeset/121489>
Adam Barth
Comment 7 2012-06-28 17:01:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.