Bug 90170

Summary: [EFL] Add Gamepad support
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, gyuyoung.kim, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2012-06-28 06:28:54 PDT
The EFL port does not currently support Gamepads. I'm planning to add support by using udev, via the EEZE library.
Attachments
Patch (19.64 KB, patch)
2012-06-29 07:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.57 KB, patch)
2012-06-29 11:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.17 KB, patch)
2012-06-29 11:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-06-28 10:55:30 PDT
EEZE library does not currently support JOYSTICK devices so I wrote a patch for it: http://trac.enlightenment.org/e/ticket/1100
Chris Dumez
Comment 2 2012-06-29 07:08:59 PDT
Created attachment 150170 [details] Patch
Chris Dumez
Comment 3 2012-06-29 10:01:02 PDT
Comment on attachment 150170 [details] Patch Clearing flags for now.
Chris Dumez
Comment 4 2012-06-29 11:35:17 PDT
Created attachment 150225 [details] Patch Actually tested with a gamepad and fixed a few bugs.
Chris Dumez
Comment 5 2012-06-29 11:39:59 PDT
Created attachment 150229 [details] Patch Fix changelog entries.
Gyuyoung Kim
Comment 6 2012-06-30 16:41:28 PDT
Comment on attachment 150229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150229&action=review > Source/cmake/FindEFL.cmake:7 > + eina>=1.2.0 I bump efl libraries version on Bug 90333 because of supporting network information APIs. I wonder whether Bug 90333 can support this patch as well.
Kenneth Rohde Christiansen
Comment 7 2012-07-01 19:10:32 PDT
Comment on attachment 150229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150229&action=review > Source/WebCore/platform/efl/GamepadsEfl.cpp:208 > +void GamepadsEfl::updateGamepadList(GamepadList* into) into?
Gyuyoung Kim
Comment 8 2012-07-01 19:59:24 PDT
Christophe, if possible, I would like to land Bug 90333. So, could you let me know if Bug 90333 can support this patch as well?
Chris Dumez
Comment 9 2012-07-01 22:29:13 PDT
(In reply to comment #7) > (From update of attachment 150229 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150229&action=review > > > Source/WebCore/platform/efl/GamepadsEfl.cpp:208 > > +void GamepadsEfl::updateGamepadList(GamepadList* into) > > into? Yes, I copied the prototype from Gamepads.h in WebCore/platform: void sampleGamepads(GamepadList* into);
Gyuyoung Kim
Comment 10 2012-07-01 22:32:57 PDT
*** Bug 90333 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 11 2012-07-01 23:22:31 PDT
Comment on attachment 150229 [details] Patch Clearing flags on attachment: 150229 Committed r121657: <http://trac.webkit.org/changeset/121657>
WebKit Review Bot
Comment 12 2012-07-01 23:22:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.