Summary: | [EFL] Add Gamepad support | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gustavo, gyuyoung.kim, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2012-06-28 06:28:54 PDT
EEZE library does not currently support JOYSTICK devices so I wrote a patch for it: http://trac.enlightenment.org/e/ticket/1100 Created attachment 150170 [details]
Patch
Comment on attachment 150170 [details]
Patch
Clearing flags for now.
Created attachment 150225 [details]
Patch
Actually tested with a gamepad and fixed a few bugs.
Created attachment 150229 [details]
Patch
Fix changelog entries.
Comment on attachment 150229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150229&action=review > Source/cmake/FindEFL.cmake:7 > + eina>=1.2.0 I bump efl libraries version on Bug 90333 because of supporting network information APIs. I wonder whether Bug 90333 can support this patch as well. Comment on attachment 150229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150229&action=review > Source/WebCore/platform/efl/GamepadsEfl.cpp:208 > +void GamepadsEfl::updateGamepadList(GamepadList* into) into? Christophe, if possible, I would like to land Bug 90333. So, could you let me know if Bug 90333 can support this patch as well? (In reply to comment #7) > (From update of attachment 150229 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150229&action=review > > > Source/WebCore/platform/efl/GamepadsEfl.cpp:208 > > +void GamepadsEfl::updateGamepadList(GamepadList* into) > > into? Yes, I copied the prototype from Gamepads.h in WebCore/platform: void sampleGamepads(GamepadList* into); *** Bug 90333 has been marked as a duplicate of this bug. *** Comment on attachment 150229 [details] Patch Clearing flags on attachment: 150229 Committed r121657: <http://trac.webkit.org/changeset/121657> All reviewed patches have been landed. Closing bug. |