Bug 8974
Summary: | REGRESSION: notes cannot be created at google/notebook | ||
---|---|---|---|
Product: | WebKit | Reporter: | tim bates <timothy.c.bates> |
Component: | Evangelism | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | abob, ampcoder, ddkilzer, ian, joost, markmalone, mrowe, webkit |
Priority: | P2 | Keywords: | GoogleBug, HasReduction, InRadar, Regression |
Version: | 420+ | ||
Hardware: | Mac | ||
OS: | OS X 10.4 | ||
URL: | http://www.google.com/notebook/fullpage |
tim bates
This is a very vague bug, i know. but google/notebooks doesn't function properly.
you can click the create note button once, and the word processor UI builds, but you can't enter text, and the create button is then broken.
write once once debug everywhere i know, but they will support firefox, which means mac users will move there if safari is "broken".
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Joost de Valk (AlthA)
Adding GoogleBug keyword in one big change.
Sam Weinig
Confirming that you cannot edit newly created notes in ToT. Interestingly, it works somewhat in shipping Safari (as of 10.4.7) although not correctly, but a notable regression is evident.
David Kilzer (:ddkilzer)
Adding NeedsRadar keyword, although I'm not sure whether this one would qualify since the functionality is only partially working in shipping Safari.
Alice Liu
<rdar://problem/4631597>
Maciej Stachowiak
The reason this is failing is that Google Notebook now thinks TOT Safari is Mozilla, so it uses designMode instead of contentEditable, which fails grievously. The reason is they use this check for Mozilla:
return this.Run(document.implementation && document.implementation.createDocument && !document.contains) != false;
and this for Safari:
return this.Run(document.implementation && document.implementation.createDocument && document.contains) != false;
Safari used to have document.contains on the Document node as a weird Safari-specific quirk (for some reason contains was implemented on Node instead of Element) but we have now fixed this. I think the right action is to ask Google to fix this on their end.
David Kilzer (:ddkilzer)
Perhaps Bob knows who to talk to at Google to get this fixed. This resource describes the preferred way to detect WebKit:
http://trac.webkit.org/projects/webkit/wiki/DetectingWebKit
Reduction found in Comment #5.
Robert Blaut
I sent bug report to Google Notebook team a while ago and got answer:
Date: Wed, 14 Nov 2007 19:04:13 -0000
From: notebook-support@google.com
Subject: Re: [#214346367] Notes cannot be created with Safari browser
Thank you for taking the time to report this problem. We've forwarded your note to the Notebook engineering team for investigation. We appreciate your assistance as we work to improve Google Notebook.
Regards,
The Google Team
Notebook still doesn't work :(
mitz
*** Bug 17416 has been marked as a duplicate of this bug. ***
Robert Blaut
After checking Google Notebook today, I can say that the reported issue is no longer visible. Additionally, it seems that Safari/Webkit is currently fully supported by Google Notebook (except an extension ;) [http://www.google.com/googlenotebook/faq.html#extensionsupport]
I close the bug as FIXED. Please close the Radar bug as well.