Bug 89587

Summary: IndexedDB: Remove redundant IDBObjectStore.delete() overloads
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dglazkov, dgrogan, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Joshua Bell
Reported 2012-06-20 11:33:09 PDT
IndexedDB: Remove redundant IDBObjectStore.delete() overloads
Attachments
Patch (30.42 KB, patch)
2012-06-20 11:55 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.53 KB, patch)
2012-06-20 14:28 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-06-20 11:55:52 PDT
Created attachment 148617 [details] Patch
Joshua Bell
Comment 2 2012-06-20 11:56:55 PDT
alecflett@ - can you take an initial look? Chromium WebKit API reviewers - please, sir, may I delete some code?
WebKit Review Bot
Comment 3 2012-06-20 11:57:36 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Alec Flett
Comment 4 2012-06-20 13:37:44 PDT
LGTM - you're gonna collide with https://bugs.webkit.org/show_bug.cgi?id=86123 (or I'll collide with you, either way :))
WebKit Review Bot
Comment 5 2012-06-20 14:20:41 PDT
Comment on attachment 148617 [details] Patch Rejecting attachment 148617 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 37 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 37. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13008329
Joshua Bell
Comment 6 2012-06-20 14:28:07 PDT
Created attachment 148655 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-06-20 17:32:00 PDT
Comment on attachment 148655 [details] Patch for landing Clearing flags on attachment: 148655 Committed r120888: <http://trac.webkit.org/changeset/120888>
WebKit Review Bot
Comment 8 2012-06-20 17:32:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.