Bug 89324

Summary: [TextureMapper] Rename shader variables to match the naming scheme of the newer filter shaders
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: PlatformAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89317    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cq-03 none

Martin Robinson
Reported 2012-06-17 22:31:55 PDT
The newer filter shaders use a naming scheme much like the one that the Chromium compositor uses. It makes sense to bring the older shaders in line with this scheme.
Attachments
Patch (10.28 KB, patch)
2012-06-17 22:48 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cq-03 (1.12 MB, application/zip)
2012-06-18 11:40 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-06-17 22:48:27 PDT
Created attachment 148055 [details] Patch
WebKit Review Bot
Comment 2 2012-06-18 11:40:45 PDT
Comment on attachment 148055 [details] Patch Rejecting attachment 148055 [details] from commit-queue. New failing tests: http/tests/security/script-crossorigin-loads-correctly.html Full output: http://queues.webkit.org/results/12979226
WebKit Review Bot
Comment 3 2012-06-18 11:40:50 PDT
Created attachment 148139 [details] Archive of layout-test-results from ec2-cq-03 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
WebKit Review Bot
Comment 4 2012-06-18 13:36:04 PDT
Comment on attachment 148055 [details] Patch Clearing flags on attachment: 148055 Committed r120623: <http://trac.webkit.org/changeset/120623>
WebKit Review Bot
Comment 5 2012-06-18 13:36:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.