Bug 89317

Summary:

[TextureMapper] Replace the source transform with a flip uniform

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

Platform

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

noam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

89293

Bug Blocks:

89324

Attachments:

Description	Flags
Patch	none

Description Martin Robinson 2012-06-17 16:13:08 PDT

Instead of passing an entire transformation matrix to flip source textures, it should be enough to simply pass a single float denoting whether or not to flip the texture. This will also be easier to integrate into the edge distance antialiasing shader.

Comment 1 Martin Robinson 2012-06-17 22:27:18 PDT

Created attachment 148053 [details]
Patch

Comment 2 WebKit Review Bot 2012-06-17 22:44:54 PDT

Comment on attachment 148053 [details]
Patch

Rejecting attachment 148053 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 to file Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp.rej
patching file Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h
Hunk #1 FAILED at 52.
Hunk #2 FAILED at 71.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Noam Rosen..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12970589

Comment 3 WebKit Review Bot 2012-06-18 10:24:11 PDT

Comment on attachment 148053 [details]
Patch

Clearing flags on attachment: 148053

Committed r120608: <http://trac.webkit.org/changeset/120608>

Comment 4 WebKit Review Bot 2012-06-18 10:24:17 PDT

All reviewed patches have been landed.  Closing bug.