Bug 89268 – [EFL][WK2] Support keyboard event

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

There is currently no way to write text in contents using keyboard.

[Ryuan Choi]

Created attachment 147943 [details]
Patch

[WebKit Review Bot]

Comment on attachment 147943 [details]
Patch

Attachment 147943 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12960819

New failing tests:
svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox.svg
svg/custom/image-small-width-height.svg

[WebKit Review Bot]

Created attachment 147957 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ryuan Choi]

Created attachment 147966 [details]
rebased for green ews

[WebKit Review Bot]

Comment on attachment 147966 [details]
rebased for green ews

Attachment 147966 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12961888

New failing tests:
svg/custom/focus-ring.svg
svg/custom/group-opacity.svg
svg/custom/createImageElement2.xhtml
scrollbars/listbox-scrollbar-combinations.html
svg/as-border-image/svg-as-border-image.html
scrollbars/overflow-scrollbar-combinations.html
svg/custom/image-parent-translation.xhtml
svg/custom/createImageElement.svg

[WebKit Review Bot]

Created attachment 147976 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Ryuan Choi]

(In reply to comment #5)
> (From update of attachment 147966 [details])
> Attachment 147966 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12961888
> 
> New failing tests:
> svg/custom/focus-ring.svg
> svg/custom/group-opacity.svg
> svg/custom/createImageElement2.xhtml
> scrollbars/listbox-scrollbar-combinations.html
> svg/as-border-image/svg-as-border-image.html
> scrollbars/overflow-scrollbar-combinations.html
> svg/custom/image-parent-translation.xhtml
> svg/custom/createImageElement.svg

I can not understand failing because this patch is just for Efl specific.
I will try once more.

[Ryuan Choi]

Created attachment 148450 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 148450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148450&action=review

From refactoring of view, I agree with this change for both WK1 and WK2.

> Source/WebCore/ChangeLog:3
> +        [EFL][WK2] Add to support keyboard event.

I think "[EFL][WK2] Support keyboard event" is clear.

[Ryuan Choi]

Created attachment 148515 [details]
patch for green bot

[Ryuan Choi]

(In reply to comment #9)
> (From update of attachment 148450 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148450&action=review
> 
> From refactoring of view, I agree with this change for both WK1 and WK2.
> 
> > Source/WebCore/ChangeLog:3
> > +        [EFL][WK2] Add to support keyboard event.
> 
> I think "[EFL][WK2] Support keyboard event" is clear.

Ok, I changed.

[Gyuyoung Kim]

Comment on attachment 148515 [details]
patch for green bot

View in context: https://bugs.webkit.org/attachment.cgi?id=148515&action=review

LGTM.

> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:43
> +    if (m_page->handleEditingKeyboardEvent(event))

I think we can use this function in WebEditorClient.cpp as other ports.

http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp#L279

[Gyuyoung Kim]

(In reply to comment #12)
> (From update of attachment 148515 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148515&action=review
> 
> LGTM.

*LGTM* is my mistake.

[Ryuan Choi]

(In reply to comment #12)
> (From update of attachment 148515 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148515&action=review
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:43
> > +    if (m_page->handleEditingKeyboardEvent(event))
> 
> I think we can use this function in WebEditorClient.cpp as other ports.
> 
> http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp#L279

Yes, now they are same.
so we can remove WebEditorClientEfl for now.

But, I am not sure because it should be modified to support ecore-imf in the near future.

[Gyuyoung Kim]

Comment on attachment 148515 [details]
patch for green bot

View in context: https://bugs.webkit.org/attachment.cgi?id=148515&action=review

>>> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:43
>>> +    if (m_page->handleEditingKeyboardEvent(event))
>> 
>> I think we can use this function in WebEditorClient.cpp as other ports.
>> 
>> http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp#L279
> 
> Yes, now they are same.
> so we can remove WebEditorClientEfl for now.
> 
> But, I am not sure because it should be modified to support ecore-imf in the near future.

If you're going to submit it, maybe, within a week, I would like to wait for the patch. But, if not so, I think it is good to remove WebEditorClientEfl.cpp for now. We need to stop to keep unneeded file / stub functions.

[Gyuyoung Kim]

If you file a bug for ecore-imf first, I agree to land this patch. Because, EFL WK2 is being to contributed.

[Ryuan Choi]

(In reply to comment #16)
> If you file a bug for ecore-imf first, I agree to land this patch. Because, EFL WK2 is being to contributed.

OK, I created Bug 89552

[Gyuyoung Kim]

Comment on attachment 148515 [details]
patch for green bot

Looks good to me now.

[Chang Shu]

Comment on attachment 148515 [details]
patch for green bot

LGTM, too.

[WebKit Review Bot]

Comment on attachment 148515 [details]
patch for green bot

Clearing flags on attachment: 148515

Committed r121068: <http://trac.webkit.org/changeset/121068>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.