Bug 89552 – [EFL][WK2] Add support for IMF composition

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

The WebKit2/Efl should support input method framework.

[Ryuan Choi]

Created attachment 165063 [details]
WIP:basic implementation

[Ryuan Choi]

Comment on attachment 165063 [details]
WIP:basic implementation

This should be cooked more.

[Ryuan Choi]

Created attachment 167223 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 167223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=167223&action=review

> Source/WebKit2/PlatformEfl.cmake:204
> +    ${ECORE_IMF_LIBRARIES}

Wrong alphabetical order.

> Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:77
> +        EINA_LOG_DOM_CRIT(_ewk_log_dom, "could not init ecore_imf.");

ewk_private.h defined simple macros for this. Use CRITICAL macro.

> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:56
> +    // FIXME : sending sync message might make input lagging.

FIXME : -> FIXME:

> Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp:176
> +    }

A new line ?

[Ryuan Choi]

(In reply to comment #3)
> Created an attachment (id=167223) [details]
> Patch

Rebased and added some comments.

I was digging the issue which inserts preedit string two times when focus was moved.
But, I realized that it is because of ecore_imf with xim.

After tested using ecore_imf with scim (and scim-hangul - for korean),
I it works logically.

[Ryuan Choi]

Created attachment 167227 [details]
Patch

[Ryuan Choi]

(In reply to comment #4)
> (From update of attachment 167223 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=167223&action=review
> 
> > Source/WebKit2/PlatformEfl.cmake:204
> > +    ${ECORE_IMF_LIBRARIES}
> 
> Wrong alphabetical order.
> 
Done.

> > Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:77
> > +        EINA_LOG_DOM_CRIT(_ewk_log_dom, "could not init ecore_imf.");
> 
> ewk_private.h defined simple macros for this. Use CRITICAL macro.
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:56
> > +    // FIXME : sending sync message might make input lagging.
> 
> FIXME : -> FIXME:
Done.

> 
> > Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp:176
> > +    }
> 
> A new line ?
Done.

Thank you.

[Ryuan Choi]

Created attachment 167898 [details]
Patch

[Ryuan Choi]

(In reply to comment #8)
> Created an attachment (id=167898) [details]
> Patch

Rebased and fixed warning and bug which continues composition when clicked same input field.

[Ryuan Choi]

Created attachment 170061 [details]
Patch

[Ryuan Choi]

(In reply to comment #10)
> Created an attachment (id=170061) [details]
> Patch

just rebased.

[Gyuyoung Kim]

Comment on attachment 170061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170061&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:52
> +    Frame* frame = m_page->corePage()->focusController()->focusedOrMainFrame();

Looks make sense. BTW, don't you need to move this to new function as mac port ?

[Ryuan Choi]

(In reply to comment #12)
> (From update of attachment 170061 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170061&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:52
> > +    Frame* frame = m_page->corePage()->focusController()->focusedOrMainFrame();
> 
> Looks make sense. BTW, don't you need to move this to new function as mac port ?

IMO, current one looks enough until we have more requirements.

Mac port has specific handleEditingKeyboardEvent for keyboardEvent and InputMethodKeydown.
But, we share handleEditingKeyboardEvent with other ports and I think that this is simple.

[WebKit Review Bot]

Comment on attachment 170061 [details]
Patch

Clearing flags on attachment: 170061

Committed r132210: <http://trac.webkit.org/changeset/132210>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.