Bug 88981 – Unhide login form on the build.webkit.org

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

It is hidden now with the header. After unhide it,
we can stop builds and cancel pending builds.
(And force builds after adding ForceScheduler)

Patch is coming soon.

[Csaba Osztrogonác]

Created attachment 147280 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 147280 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147280&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:-1
> -div.header { display: none; }

Unhide the header to unhide the login form.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:18
> +.auth (
> +position:absolute;
> +top:5px;
> +right:40px;
> +)
> +

Copied from buildbot-0.8.6p1/buildbot/status/web/files/default.css
to dock login form to the top-left side of the windows.

[Peter Gal]

View in context: https://bugs.webkit.org/attachment.cgi?id=147280&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:17
> +.auth (
> +position:absolute;
> +top:5px;
> +right:40px;
> +)

I think you wanted to use curly brackets and indentation like everywhere else.

[Csaba Osztrogonác]

(In reply to comment #3)
> View in context: https://bugs.webkit.org/attachment.cgi?id=147280&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:17
> > +.auth (
> > +position:absolute;
> > +top:5px;
> > +right:40px;
> > +)
> 
> I think you wanted to use curly brackets and indentation like everywhere else.

As I said it was copy/paste code from buildbot. So you found this bug in buildbot. :))

[Csaba Osztrogonác]

Created attachment 147316 [details]
Patch

CSS bug fixed

[WebKit Review Bot]

Attachment 147316 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:14:  Line contains tab character.  [whitespace/tab] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:15:  Line contains tab character.  [whitespace/tab] [5]
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:16:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Lucas Forschler]

R+ after Tabs are removed and style check passes.

[Csaba Osztrogonác]

Created attachment 147630 [details]
Patch

fixed patch + style fix (s/TAB/4 spaces/g)

[Build Bot]

Comment on attachment 147630 [details]
Patch

Attachment 147630 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12964270

[Csaba Osztrogonác]

Landed in http://trac.webkit.org/changeset/120351